Getting Undefined Function error while running mariaex tests

maqbool · February 5, 2018, 5:21am

I was running the mariaex tests I was getting following error

** (UndefinedFunctionError) function Mix.Shell.cmd/2 is undefined or private. Did you mean one of: * cmd/3

but in this case it wasn’t then i passed explicitly [] and then tests starts working is this is a elixir issue or mariaex?

or I’m making a mistake

github.com

xerions/mariaex/blob/e9eb29f909196655efc442353fefd264e24bf73d/test/test_helper.exs#L7


ExUnit.configure exclude: [ssl_tests: :true, json: System.get_env("JSON_SUPPORT") != "true"]
ExUnit.start()


run_cmd = fn cmd ->
  key = :ecto_setup_cmd_output
  Process.put(key, "")
  status = Mix.Shell.cmd(cmd, fn(data) ->
    current = Process.get(key)
    Process.put(key, current <> data)
  end)
  output = Process.get(key)
  Process.put(key, "")
  {status, output}
end


mysql_pass_switch = if mysql_root_pass = System.get_env("MYSQL_ROOT_PASSWORD") do
  "-p#{mysql_root_pass}"

kip · February 5, 2018, 6:08am

The signature of Mix.Shell.cmd/3 is

def cmd(command, options, callback)

And you’ll note that options has no default and therefore is required to be provided.

If you provide options as [] then it will default the option :env to []. It doesn’t mean that options itself has a default.

So I would say all is working according to specification.

maqbool · February 9, 2018, 9:18am

This Pull request fixed the issue of Undefined function error in elixir 1.6