sharkmyster

sharkmyster

I’m working on a game app that has an answers table and a categories table. This relationship is many to many.

The admins for the app can add answers and categories individually using usual controller format. However, I want to create a way to bulk associate answers to categories. On a category page there is a textarea to receive a comma separated list of strings. Upon hitting submit, I want to achieve the following steps,

  • assess if any of the strings already exist as an answer
  • for any that do not exist, create an record in the answers table
  • for all the answers that were given, create the association in the join table

Here is my attempt.

  def put_answers_to_category(category, answers_string) do
    answers =
      answers_string
      |> parse_answers_string()
      |> find_existing_and_create_new()

    old_category =
      category
      |> Repo.preload(:answers)
      |> IO.inspect()

    category
    |> Ecto.Changeset.change()
    |> Ecto.Changeset.put_assoc(:answers, Enum.uniq(answers ++ old_category.answers))
    |> IO.inspect()
    |> Repo.update()
  end

  def parse_answers_string(answers_string) do
    answers_string
    |> String.split(",", trim: true)
    |> Enum.map(&String.trim/1)
    |> Enum.reject(&(&1 == ""))
  end

  def find_existing_and_create_new(answers_list) do
    existing_answers =
      Answer
      |> where([a], a.raw in ^answers_list)
      |> Repo.all()

    existing_answers_raw = Enum.map(existing_answers, & &1.raw)

    new_answers =
      answers_list
      |> Enum.filter(fn ans -> !Enum.member?(existing_answers_raw, ans) end)
      |> Enum.map(fn ans -> %{raw: ans} end)
      |> Enum.map(&create_answer/1)
      |> Enum.map(fn {:ok, answer} -> answer end)

    existing_answers ++ new_answers
  end

This seems to be working but I think it may be verbose/inefficient. I’ve read the docs around cast_assoc and put_assoc but I couldn’t quite find a better way. Is there a better/more efficient way to do this?

Showing Posts 1 to 2

tfwright

tfwright

As far as Ecto goes, I think that your implementation is the proper way to approach updating a many_to_many. But that really just means using put_assoc with an array of the set of answer records you want the category changeset to have.

The rest of the complexity here comes from the bulk upsert on the answer text param, but changing that would require a different API design. For example, a more conventional many_to_many update would take the answer ids directly, requiring them to all already exist. For example, the FE could be upserting them individually as they are entered via another endpoint.

Don’t know enough about your requirements to comment on whether that would be better overall, but I would say that you lose a significant advantage of your current approach by creating the new answers in a separate DB transaction (AFAICT), which means if the category update never goes through for whatever reason (validation error) the new answers will still be around in your DB, which may be unexpected.

sharkmyster

sharkmyster OP

Thank you, this was helpful.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews