Live_modal fails - Phoenix Liveview 0.17.6 and Phoenix 1.6.6

Questions / Help
, ,
1

I am getting an error on all of my code that calls live_modal. As soon as I change it to live_component, everything works:

FAILS:

<%= if @live_action in [:show] do %>
        <%= live_modal @socket, MyAppWeb.ResourceformLive.ComponentShowResource,
          id: @resourceform.id,
          page_title: @page_title,
          action: @live_action,
          resourceform: @resourceform,
          return_to: Routes.resourceform_index_path(@socket, :index) %>
      <% end %>

WORKS:

<%= if @live_action in [:show] do %>
        <%= live_component @socket, MyAppWeb.ResourceformLive.ComponentShowResource,
          id: @resourceform.id,
          page_title: @page_title,
          action: @live_action,
          resourceform: @resourceform,
          return_to: Routes.resourceform_index_path(@socket, :index) %>
      <% end %>

ERROR:

[error] GenServer #PID<0.1065.0> terminating
** (ArgumentError) error on MyAppWeb.ModalComponent.render/1 with id of :modal. Stateful components must return a HEEx template (~H sigil or .heex extension)
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:350: Phoenix.LiveView.Diff.component_to_rendered/3
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:652: Phoenix.LiveView.Diff.render_component/9
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:603: anonymous fn/5 in Phoenix.LiveView.Diff.render_pending_components/6
    (elixir 1.13.2) lib/enum.ex:2396: Enum."-reduce/3-lists^foldl/2-0-"/3
    (stdlib 3.17) maps.erl:410: :maps.fold_1/3
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:576: Phoenix.LiveView.Diff.render_pending_components/6
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:145: Phoenix.LiveView.Diff.render/3
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/channel.ex:769: Phoenix.LiveView.Channel.render_diff/3
    (phoenix_live_view 0.17.6) lib/phoenix_live_view/channel.ex:625: Phoenix.LiveView.Channel.handle_changed/4
    (stdlib 3.17) gen_server.erl:695: :gen_server.try_dispatch/4
    (stdlib 3.17) gen_server.erl:771: :gen_server.handle_msg/6
    (stdlib 3.17) proc_lib.erl:236: :proc_lib.wake_up/3
Last message: %Phoenix.Socket.Message{event: "event", join_ref: "10", payload: %{"event" => "show", "type" => "click", "value" => %{"id" => "1"}}, ref: "11", topic: "lv:phx-Fs6KkduVYgh-ZwIE"}

All of my components have been updated with the new ~H which is what made this hard to troubleshoot. For now, I’m just going to drop live_modal and convert everything to live_component.

2

SOLUTION:
Arg … stupid mistake. I completely missed fixing modal_component.ex. That was what causing all of the problems. Once I updated that with the Phoenix 1.6 requirements, modal worked again.