Hello,
I am trying to setup test for a simple crud application. I am also utilizing the POW library. I am running into a problem when I am trying to test my update_user/2
function.
accounts.ex
defmodule Profilo.Accounts do
import Ecto.Query, warn: false
alias Profilo.Repo
alias Profilo.Accounts.Lib.User
alias Bcrypt
def list_users do
Repo.all(User)
end
def get_user!(id) do
User
|> Repo.get!(id)
end
def create_user(attrs \\ %{}) do
%User{}
|> User.changeset(attrs)
|> Repo.insert()
end
def update_user(%User{} = user, attrs) do
user
|> User.changeset(attrs)
|> Repo.update()
end
def change_user(%User{} = user) do
user
|> User.changeset(%{})
end
def delete_user(%User{} = user) do
user
|> Repo.delete()
end
end
accounts_test.exs:
describe "users" do
alias Profilo.Accounts.Lib.User
@valid_attrs %{email: "test@gmail.com", password: "1234567890", current_password: "1234567890", confirm_password: "1234567890", address: "some address", company: "some company", first_name: "some first_name", last_name: "some last_name", phone_number: "some phone_number", website: "some website"}
@update_attrs %{email: "test@gmail.com", address: "some updated address", company: "some updated company", first_name: "some updated first_name", last_name: "some updated last_name", phone_number: "some updated phone_number", website: "some updated website"}
@invalid_attrs %{address: nil, company: nil, first_name: nil, last_name: nil, phone_number: nil, website: nil, email: nil, password_hash: nil}
def user_fixture(attrs \\ %{}) do
{:ok, user} =
attrs
|> Enum.into(@valid_attrs)
|> Accounts.create_user()
user
end
def update_password(%User{} = user, %{confirm_password: confirm_password, current_password: current_password, password: password}) do
user
|> Map.put(:confirm_password, confirm_password)
|> Map.put(:current_password, current_password)
|> Map.put(:password, password)
end
test "list_users/0 returns all users" do
user = user_fixture() |> update_password(%{current_password: nil, confirm_password: nil, password: nil})
assert Accounts.list_users() == [user]
end
test "get_user!/1 returns the user with given id" do
user = user_fixture() |> update_password(%{current_password: nil, confirm_password: nil, password: nil})
assert Accounts.get_user!(user.id) == user
end
test "create_user/1 with valid data creates a user" do
assert {:ok, %User{} = user} = Accounts.create_user(@valid_attrs)
assert user.email == "test@gmail.com"
assert user.address == "some address"
assert user.company == "some company"
assert user.first_name == "some first_name"
assert user.last_name == "some last_name"
assert user.phone_number == "some phone_number"
assert user.website == "some website"
end
test "create_user/1 with invalid data returns error changeset" do
assert {:error, %Ecto.Changeset{}} = Accounts.create_user(@invalid_attrs)
end
test "update_user/2 with valid data updates the user" do
user = user_fixture()
assert {:ok, %User{} = user} = Accounts.update_user(user, @update_attrs)
assert user.address == "some updated address"
assert user.company == "some updated company"
assert user.first_name == "some updated first_name"
assert user.last_name == "some updated last_name"
assert user.phone_number == "some updated phone_number"
assert user.website == "some updated website"
end
test "update_user/2 with invalid data returns error changeset" do
user = user_fixture()
assert {:error, %Ecto.Changeset{}} = Accounts.update_user(user, @invalid_attrs)
assert user == Accounts.get_user!(user.id)
end
test "delete_user/1 deletes the user" do
user = user_fixture()
assert {:ok, %User{}} = Accounts.delete_user(user)
assert_raise Ecto.NoResultsError, fn -> Accounts.get_user!(user.id) end
end
test "change_user/1 returns a user changeset" do
user = user_fixture()
assert %Ecto.Changeset{} = Accounts.change_user(user)
end
end
end
user.ex
defmodule Profilo.Accounts.Lib.User do
use Ecto.Schema
use Pow.Ecto.Schema
use PowAssent.Ecto.Schema
import Ecto.Changeset
alias Bcrypt
schema "users" do
has_many :user_identities,
Profilo.Accounts.Lib.UserIdentity,
on_delete: :delete_all,
foreign_key: :user_id
field :first_name, :string
field :last_name, :string
field :address, :string
field :company, :string
field :phone_number, :string
field :website, :string
field :is_admin, :boolean, default: false
pow_user_fields()
timestamps()
end
@required_fields ~w(first_name last_name)a
@optional_fields ~w(address company phone_number website)a
def changeset(user, attrs) do
user
|> pow_changeset(attrs)
|> cast(attrs, @required_fields ++ @optional_fields)
|> validate_required(@required_fields)
end
end
What i think the problem is:
- I feel like I should test POW update separately from my update function. As seen from the error below,
Pow.Ecto.Schema.Changeset.validate_current_password/3
requiires 3 arguments but when I call myupdate_user/2
I can only pass in 2 arguments. I am unclear as to how i should approach this
There error I am getting:
1) test users change_user/1 returns a user changeset (Profilo.AccountsTest)
test/profilo/accounts/accounts_test.exs:79
** (FunctionClauseError) no function clause matching in Pow.Ecto.Schema.Changeset.validate_current_password/2
The following arguments were given to Pow.Ecto.Schema.Changeset.validate_current_password/2:
# 1
#Ecto.Changeset<action: nil, changes: %{}, errors: [], data: #Profilo.Accounts.Lib.User<>, valid?: true>
# 2
[]
Attempted function clauses (showing 1 out of 1):
defp validate_current_password(%{data: user, changes: %{current_password: password}} = changeset, config)
code: assert %Ecto.Changeset{} = Accounts.change_user(user)
stacktrace:
(pow) lib/pow/ecto/schema/changeset.ex:124: Pow.Ecto.Schema.Changeset.validate_current_password/2
(profilo) lib/profilo/accounts/lib/user.ex:3: Profilo.Accounts.Lib.User.pow_changeset/2
(profilo) lib/profilo/accounts/lib/user.ex:34: Profilo.Accounts.Lib.User.changeset/2
test/profilo/accounts/accounts_test.exs:81: (test)