What does `restore_if_unsaved` do in the todo_trek project?

ericf · August 6, 2023, 1:02pm

Title kinda says it, but I was looking through the todo_trek project, excellent btw, and saw an event handler for the restore_if_unsaved event in TodoTrekWeb.TodoListComponent. I don’t see the event referenced anywhere in the code or phoenix_live_view code. Just curious if this is dead code or this is an event that gets fired by the framework in reaction to maybe connection failure?

Code for reference:

github.com

chrismccord/todo_trek/blob/4d7357428993ce46625e1d39cb0fda9c0a832fc6/lib/todo_trek_web/live/todo_list_component.ex#L202


      
                Todos.move_todo_to_list(socket.assigns.scope, todo, list, new_idx)
                {:noreply, socket}
            end
          end
          
          def handle_event("discard", _params, socket) do
            todo = build_todo(socket.assigns.list_id)
            {:noreply, stream_delete(socket, :todos, to_change_form(todo, %{}))}
          end
          
          def handle_event("restore_if_unsaved", %{"value" => val} = params, socket) do
            id = params["id"]
            todo = Todos.get_todo!(socket.assigns.scope, id)
          
            if todo.title == val do
              {:noreply, socket}
            else
              {:noreply, stream_insert(socket, :todos, to_change_form(todo, %{}))}
            end
          end

josevalim · August 6, 2023, 4:08pm

Looks like dead code to me. It was possible there as the project was being iterated on and the abstractions were being built.

ericf · August 6, 2023, 4:51pm

Thanks!