We support any metadata but only the keys :deprecated and :since are printed in ExDoc and IEx and so on. We will clarify the examples.
josevalim
Creator of Elixir
1
josevalim
Creator of Elixir
So I understand the current behaviour and why accumulate did not work in previous Elixir versions.
It seems that you are calling put_definition many times before you invoke accumulate: true. If I do this:
if @absinthe_definitions do
raise "omg"
end
Module.register_attribute(__MODULE__, :absinthe_definitions, accumulate: true)
You will see that @absinthe_definitions is not nil. The behaviour of setting an attribute to accumulate after it is set is “undefined”. In previous versions, we were still able of keeping whatever has been accumulated (with caveats) but in the new version we discard it.
However, I would say that the previous behaviour (in earlier Elixir versions) is also broken because your put_definition would lead to a bunch of duplicated definitions. When accumulate: true is false, put_definition works fine, but when it is enabled, you would end-up getting the whole list, prepending to it, and then adding it as an entry on top of the existing list. For example, imagine you had definitions x, y and z already stored. In the attribute, they would be stored as [:z, :y, :x]. Now imagine that you add :a, at the end you will end-up with [[:a, :z, :y, :x], :z, :y, :x]. However, it seems accumulate: true is only set too late in your suite, so this doesn’t happen there.
0
benwilson512
Author of Craft GraphQL APIs in Elixir with Absinthe
Ahh yes this makes sense, thanks for explaining, I was able to fix the issues via: fixes for Elixir 1.7.0 · absinthe-graphql/absinthe@8c62294 · GitHub
Any thoughts on the Writer module issue? I’ve hesitated to create an Elixir error before because I couldn’t reproduce it outside the Absinthe project.
1
josevalim
Creator of Elixir
Folks, please let us know if you tried the release candidate and if everything is fine. Even if you found no regressions, say so in the comments, otherwise we can’t know if everyone is quiet because nobody tried it yet or if because nobody found bugs. Hoping for the latter. 
4
mischov
The Meeseeks tests run fine using the RC and OTP21.
Edit: And a larger Phoenix 1.2 project with a bunch of deps also runs its tests fine (RC and OTP21), though it did complain that I shouldn’t use length(res) > 0 in my tests. 
2
blatyo
Conduit Core Team
I tested it with Conduit. I had to fix a warning related to System.stacktrace(). I was doing the equivalent of:
def try_a_thing do
# something might fail
rescue error ->
log_error(error)
end
def log_error(error) do
Exception.format(:error, error, System.stracktrace())
|> Logger.error()
end
Which I changed to:
def try_a_thing do
# something might fail
rescue error ->
log_error(error, System.stracktrace())
end
def log_error(error, stacktrace) do
Exception.format(:error, error, stracktrace)
|> Logger.error()
end
Otherwise everything was fine.
2
LostKobrakai
I just tried it on a project of mine and found it to not work with ex_cldr’s compiler task:
could not compile dependency :ex_cldr_dates_times, "mix compile" failed. You can recompile this dependency with "mix deps.compile ex_cldr_dates_times", update it with "mix deps.update ex_cldr_dates_times" or clean it with "mix deps.cleanex_cldr_dates_times"
** (FunctionClauseError) no function clause matching in Mix.Dep.loaded/1
The following arguments were given to Mix.Dep.loaded/1:
# 1
[env: :prod]
Attempted function clauses (showing 1 out of 1):
def loaded([])
(mix) lib/mix/dep.ex:156: Mix.Dep.loaded/1
lib/mix/tasks/compile.cldr.ex:86: Mix.Tasks.Compile.Cldr.compile_cldr_files/0
lib/mix/tasks/compile.cldr.ex:67: Mix.Tasks.Compile.Cldr.run/1
(mix) lib/mix/task.ex:316: Mix.Task.run_task/3
(mix) lib/mix/tasks/compile.all.ex:68: Mix.Tasks.Compile.All.run_compiler/2
(mix) lib/mix/tasks/compile.all.ex:52: Mix.Tasks.Compile.All.do_compile/4
(mix) lib/mix/tasks/compile.all.ex:23: anonymous fn/1 in Mix.Tasks.Compile.All.run/1
(mix) lib/mix/tasks/compile.all.ex:39: Mix.Tasks.Compile.All.with_logger_app/1
Seems like the function is deprecated: @kip
0
josevalim
Creator of Elixir
@LostKobrakai Mix.Dep.loaded/1 was private API, so folks should not be invoking it in the first place.
EDIT: I have added it back with a warning but it will be removed in the future.
0
tcoopman
I have an application that doesn’t want to start:
13:41:22.543 [info] Application schema exited: Schema.Application.start(:normal, []) returned an error: shutdown: failed to start child: Schema.Repo
** (EXIT) exited in: GenServer.call(Ecto.Registry, {:associate, #PID<0.356.0>, {Schema.Repo, Schema.Repo.Pool, [name: Schema.Repo.Pool, otp_app: :schema, repo: Schema.Repo, timeout: 15000, pool_timeout: 5000, adapter: Ecto.Adapters.Postgres, database: "argus_dev", username: "postgres", password: "secret", hostname: "localhost", pool_size: 10, pool: DBConnection.Poolboy]}}, 5000)
** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started
** (Mix) Could not start application schema: Schema.Application.start(:normal, []) returned an error: shutdown: failed to start child: Schema.Repo
** (EXIT) exited in: GenServer.call(Ecto.Registry, {:associate, #PID<0.356.0>, {Schema.Repo, Schema.Repo.Pool, [name: Schema.Repo.Pool, otp_app: :schema, repo: Schema.Repo, timeout: 15000, pool_timeout: 5000, adapter: Ecto.Adapters.Postgres, database: "argus_dev", username: "postgres", password: "secret", hostname: "localhost", pool_size: 10, pool: DBConnection.Poolboy]}}, 5000)
** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started
Schema is a path dependency. The weird thing is that I have an other application that also has a dependency on Schema and that one works fine.
Not much info here, except the above error, so not sure if this is an issue, but because I have an other application that does start and switching back to 1.6.6 fixes things, it might be an issue with rc?
0