How does one actually end up with a struct after validation and casting? Doesn’t ecto just keep everything in the changes map?
Without the Repo.insert I’m not sure how to get a struct back with the validated changes applied…
hackerboos
0
regal
wojtekmach
Hex Core Team
I only mention it because its somewhat new function (I think added in Ecto v2.2), besides apply_changes/1 there’s an apply_action/2 too.
4
PragTob
that’s good to hear… I remember working with a changeset and not even attempting to insert it in the db (cause I knew it was invalid from validations with APIs) and wondering why errors didn’t show up… turned out the standard helpers or what not would only show them if an action was present iirc. So I wrote this “dirty” feeling helper which set the action and people debated if what I was doing was right.
I feel vindicated somehow 
2
hackerboos
This looks like the correct method over apply_changes as it only applies if the changeset is valid. Thanks!
1
blatyo
Conduit Core Team
I was under the impression that changesets were going to be in ecto_sql and not ecto. I feel like José mentioned at some point that the structure of changesets was so tied to a database it didn’t make sense to break it out. Did that change?
0
josevalim
Creator of Elixir
You can see the answer (and rationale) in the issues tracker discussion: Split ecto into ecto and ecto_sql · Issue #2558 · elixir-ecto/ecto · GitHub
2
michallepicki
I feel like this split was done in the wrong direction. We all know ecto is a database access toolkit and now the database parts of it are not in the ecto repo / package. But main readme documentation and basic information for newcomers is there.
I understand this may have been easier (to split out database stuff and move it to ecto_sql) but after separating the code, I feel like the database access package should have stayed at ecto and the rest should be moved to ecto_core or something similar.
Excuse my bikeshedding 
It’s just we’ll all have to switch and the few people who use ecto without the database won’t. And I’m still not sure where soft documentation (guides) will be.
0
josevalim
Creator of Elixir
The switch is literally 1LOC change, which you would likely have to change anyway to get a version bump.
After all of the effort to keep breaking changes to a minimum… reading this is disheartening at best. 
2
michallepicki
I’m sorry, didn’t mean anything offending. The dependency change is completely fine, I was mainly worried about docs.
So the main documentation will stay at ecto, right? This was not clear to me and my main concern which I expressed in this grumpy way.
1