I have badly misread while I was on the phone. Apologies.
dimitarvp
axelson
Scenic Core Team
I believe what @hauleth was driving at is that you can restructure that code as
def handle_has_key(true), do: b
def handle_has_key(false), do: c
def main do
handle_has_key(Map.key?(a))
end
i.e. pass the result of the check into the function
Of course, I’m not advocating to write all your code in this manner, just pointing out that it is possible
2
tmbb
I would be extremely hard to do because of two things:
-
the very tenuous mapping between Elixir’s AST and the macro-expanded version. This makes it very hard to count which branches we covered, because the branches in the macro-expanded code are not necessarily related to the branches in the original code
-
It’s very hard to get the Elixir AST for a given module. You’d have to use files as compilation units, and not modules.
Maybe it’s not as hard as I think it is, but it’s certainly not very easy. It’s much easir to get access to and manipulate the Erlang abstract format. I mean, I can’t even find a way to expand something inside a defmodule into Elixir AST. That’s probably because defmodule acts more like a function that creates a module and injects it into the running BEAM instance than a macro that is expanded into something more basic.
I guess this probably means there isn’t even a “fully expanded ast” for me to look at. But there must be something that the Elixir compiler feeds into the Erlang compiler, right?
0
cblavier
Just a brief update, because I needed to get solid code coverage for a decent phoenix app (umbrella app of 5 sub-apps, 17k loc).
On the app side, we’ve been using excoveralls : it is reliable, can be run in umbrella apps, with partitioned parallel testing and can output in different formats. 
Then we needed also a good UI to be able to drill down within our application code to know what to test to improve our code coverage. I tested:
-
coveralls.io: the UI is only OK but not really convenient nor pretty. I could not make Github Status checks or comments to work (in order to get instant code coverage feedback when opening a pull request). Integration in the CI was not really convenient as well because we had to disable partitioned testing to run all tests at once and upload a single report.
-
codeclimate.com was disapointing
Integration within CI was ok : we had to generate multiple json reports (one per partition) with excoverallsthen format them, merge them and upload the whole withcc_test_reporter(binary provided by code_climate). Github feedback is working well, but you can’t really explore your code source tree within codeclimate UI. No go
-
codecov.io is our choice. Integration within the CI is really simple : you can upload multiple report for a single build (one per test partition) and everything will be merged on the serverside. Github feedback is really insightful and the UI gives you the ability to drill down as you want to build your test coverage strategy
11
Fl4m3Ph03n1x
cblavier
Look at my repo here: