There is an open PR to support it.
hubertlepicki
ijunaidfarooq
when they will merge? is there time span on that?
I am going to switch from HTTPoison to Finch, and the whole application based on sending multipart requests.
0
hubertlepicki
I think they will but need some minor tweaks in terms of naming things I thunk. I will try to do it tonight and let you know. Nothing from API should change so I guess you can try from my branch/pr, in fact, another pair of eyes testing this would be very much welcome.
niedz., 13 gru 2020, 14:01 użytkownik Ijunaidfarooq via Elixir Programming Language Forum <noreply@forum.elixirforum.com> napisał:
0
ijunaidfarooq
achempion
It seems like they can solve your issue. Why do you think using them wouldn’t fit into your project?
0
hubertlepicki
I could use hackney directly, yes, and I have been doing it but it’s a low level API. As far as I know, and I inspected HTTPoison code pretty intensely to find a way to do it, it can’t stream request body. It can stream the response from the server, but it doesn’t allow me to stream request. I think hackney or ibrowse (or a Tesla wrapper for either) used directly could do it, however.
0
hubertlepicki
And I think you may have asked here about documentation and you are right, once my PR is merged I will work on some documentation to how to use it. I suppose you figured out the way to use http basic auth but otherwise hit me up, I am doing the same.
0
ijunaidfarooq
I did this way
credentials = "#{username}:#{password}" |> Base.encode64()
EvercamFinch.request(:get, url, [Authorization: "Basic #{credentials}"])
and module is
defmodule EvercamFinch do
def request(method, url, headers \\ [], body \\ nil, opts \\ []) do
transformed_headers = tranform_headers(headers)
request = Finch.build(method, url, transformed_headers, body)
case Finch.request(request, __MODULE__, opts) do
{:ok, %Finch.Response{} = response} ->
{:ok, response}
{:error, reason} ->
{:error, reason}
end
end
defp tranform_headers([]), do: []
defp tranform_headers(headers) do
headers
|> Enum.map(fn({k, v}) ->
{Atom.to_string(k), v}
end)
end
end
are you doing any different?
1
ijunaidfarooq
Hi, I am little confused about the PR you pointed me out, on Finch.
my use case is, I am trying to send a multipart request using Finch.
in past with HTTPoison. it was like this
HTTPoison.post(
url,
{:multipart, [{file_path, image, []}]},
[],
hackney: [pool: :seaweedfs_upload_pool, recv_timeout: 15_000]
)
URL = http://localhost:8888/everc-dupzo/snapshots/oldest-1572566369.jpg
file_path = /snapshots/oldest-1572566369.jpg
and the image is a binary data, which you can get while doing File.read!.
I have done every other replacement of HTTPoison but this has become a road blocker for me.
I have also tried to do simple post request using the data but it’s not working either.
Can you guide me how I Can send an Image binary data as a multipart request?
NOTE: in above HTTPoison request, the image is not saved on disk at all.
0
hubertlepicki
I don’t think Finch supports building actual multipart body. This is a task on it’s own.
What I am doing is using Tesla to help me out with that task.
First, build multipart body using Tesla.Multipart
multipart =
Multipart.new()
|> Multipart.add_content_type_param("charset=utf-8")
|> add_fields(form_data)
|> add_files(file_parts)
mp_headers = Multipart.headers(multipart)
stream = Multipart.body(multipart)
headers = ... # your other headers, optional
And then you can either POST it as a streaming body request, once this PR is merged https://github.com/keathley/finch/pull/107
:post
|> Finch.build(url, headers ++ mp_headers, {:stream, stream})
|> Finch.request(YourFinch)
Or, you can POSt it in non-streaming fashion (should work on current release/master):
:post
|> Finch.build(url, headers ++ mp_headers, stream |> Enum.join())
|> Finch.request(YourFinch)
2