Oh, neat. Please open up a new issue so we can discuss how to address this!
Wlll do, thanks.
josevalim
Creator of Elixir
jswny
I’m also wondering what the use case for is_struct/1 is because pattern matching can already do The same thing with an underscore like you said.
I guess that using it inside of defining a new guard is the only new thing really?
0
dimitarvp
In my case it would be readability. %_{} isn’t exactly something that immediately catches your eye while is_struct is readily noticeable.
All subjective tastes of course. But to me is_struct has a very valid place.
0
wojtekmach
Hex Core Team
is_struct/1 allows things that are not possible with pattern matches, e.g.: when is_struct(term) or is_integer(term) and when not is_struct(term).
10
dimitarvp
bjorng
Erlang Core Team
Not sure if this is useful, but here is how erl_expand_records forces an exception in a guard:
Here is how warnings are suppressed (for both the Erlang compiler and Dialyzer):
9
lukaszsamson
ElixirLS Core Team
It does not work correctly any more. GitHub - elixir-lsp/elixir_sense: Provides context-aware information for code completion, documentation, go/jump to definition, signature info and more · GitHub, the library behind GitHub - elixir-lsp/elixir-ls: A frontend-independent IDE "smartness" server for Elixir. Implements the "Language Server Protocol" standard and provides debugger support via the "Debug Adapter Protocol" · GitHub uses Mix.Tasks.Xref.calls/0 and it does not properly register some function calls. I know that it is now deprecated but it should not be broken.
0
hauleth
This was never public interface of Mix, so there were no guarantees that this will work. This function was never safe to call.
1
lukaszsamson
ElixirLS Core Team
@josevalim can you look into this stacktrace I am getting from elixir-ls dialyzer tests?
19:59:23.538 [error] Task #PID<0.344.0> started from #PID<0.381.0> terminating
** (MatchError) no match of right hand side value: false
(elixir 1.10.0-rc.0) src/elixir_erl_var.erl:14: :elixir_erl_var.translate/4
(stdlib 3.11) lists.erl:1354: :lists.mapfoldl/3
(elixir 1.10.0-rc.0) src/elixir_erl_clauses.erl:20: :elixir_erl_clauses.match/3
(elixir 1.10.0-rc.0) src/elixir_erl_clauses.erl:28: :elixir_erl_clauses.clause/6
(elixir 1.10.0-rc.0) src/elixir_erl.erl:230: :elixir_erl.translate_clause/3
(elixir 1.10.0-rc.0) src/elixir_erl.erl:220: :elixir_erl."-translate_definition/4-lc$^0/1-0-"/2
(elixir 1.10.0-rc.0) src/elixir_erl.erl:220: :elixir_erl.translate_definition/4
(elixir 1.10.0-rc.0) src/elixir_erl.erl:183: :elixir_erl.split_definition/11
(elixir 1.10.0-rc.0) src/elixir_erl.erl:155: :elixir_erl.dynamic_form/1
(elixir 1.10.0-rc.0) src/elixir_erl.erl:126: :elixir_erl.consolidate/3
(elixir 1.10.0-rc.0) lib/protocol.ex:668: Protocol.compile/3
(mix 1.10.0-rc.0) lib/mix/tasks/compile.protocols.ex:141: Mix.Tasks.Compile.Protocols.consolidate/4
(elixir 1.10.0-rc.0) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
(elixir 1.10.0-rc.0) lib/task/supervised.ex:35: Task.Supervised.reply/5
(stdlib 3.11) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Function: #Function<9.64842280/0 in Mix.Tasks.Compile.Protocols.consolidate/6>
Args: []
I’m not sure if this is an error or is elixir-ls doing something bad.
0
NobbZ
The ls is currently not compatible with elixir 1.10 as it used “private” API that has been removed.
0