My browser is somehow sending \r\n instead of \n\r. Maybe only my case is not handled properly by lexer?
My PR is just a temporary fix and would fix bug (by workaround) much faster + it could be reverted any time.
Eiji
0
tmbb
It’s not “maybe”. I’ve just checked and the lexer doesn’t handle this case properly (if Elixir is meant to support these line endings).
0
josevalim
Creator of Elixir
To be clear, it is \r\n (as emitted by Windows) and Elixir’s parser does handle it. \n\r would not be handled.
2
josevalim
Creator of Elixir
axelson
Scenic Core Team
I’m glad that you like it! Not sure I’ll get to a “looks wrong” button/form but that is interesting. Perhaps instead of an email it could just create a DB record.
Thanks for the PR’s and the investigation, I’ll take a look at them soon!
0
alvises
Thanks @axelson, really nice project! I love how easy it is to generate the beautiful Makeup output in realtime with LiveView!
One thing, at the moment for each single change the whole textarea value is sent to the back-end and the whole highlighted code sent back to the front-end. Maybe adding some debouncing would help?
1
axelson
Scenic Core Team
Hi @alvises, thanks for the kind words! De-bouncing is a good idea so I’ve added it in Add debounce on input by axelson · Pull Request #10 · axelson/makeup_live_format · GitHub
Also if anyone is curious what a PR that updates a LiveView project from 0.4.1 to 0.11.1 they can look at: Update phoenix live view by axelson · Pull Request #8 · axelson/makeup_live_format · GitHub along with Handle removal of live_view.css by axelson · Pull Request #9 · axelson/makeup_live_format · GitHub (since I missed a breaking change the first time)
As a side-note I wish there was a way to for phx-throttle to work similarly to lodash’s throttle with leading=true and trailing=true: Lodash Documentation but that should really be a separate forum topic.
2