ah i see. I’ll have to add that to another PR
ConnorRigby
Nerves Core Team
ConnorRigby
Nerves Core Team
Tried that and it at least changed the messages.
[h264 @ 0x7f78d002a7c0] Frame num change from 0 to 1
[h264 @ 0x7f78d002a7c0] decode_slice_header error
[h264 @ 0x7f78d002a7c0] error while decoding MB 15 1, bytestream -20
[h264 @ 0x7f78d002a7c0] concealing 8074 DC, 8074 AC, 8074 MV errors in P frame
[h264 @ 0x7f78d002a7c0] error while decoding MB 39 1, bytestream -6
[h264 @ 0x7f78d002a7c0] concealing 8050 DC, 8050 AC, 8050 MV errors in P frame
[h264 @ 0x7f78d002a7c0] error while decoding MB 19 1, bytestream -12
[h264 @ 0x7f78d002a7c0] concealing 8070 DC, 8070 AC, 8070 MV errors in P frame [h264 @ 0x7f78d002a7c0] error while decoding MB 21 1, bytestream -8
0
mat-hek
Membrane Core Team
ConnorRigby
Nerves Core Team
yes they are passed to both in the same order, sps first, pps second. The decoder will error and fail completely if i don’t send both sps and pps. The parser seems to be okay without either, but sends that non-existing PPS 0 referenced error on every frame. Adding the sps and pps to the parser resulted in those errors from my last message. In either case, the video stream still works correctly
0
xlphs
You are getting video as expected but the PPS error comes with every frame? It sounds like the decoder is now overzealous in making sure sps/pps are present 
0
ConnorRigby
Nerves Core Team
yes i’m getting valid video, but every RTP frame that is parsed/decoded logs that non-existing PPS 0 referenced error. Like nothing bad seems to be happeneing, just an annoying log.
0
xlphs
mat-hek
Membrane Core Team
These logs mean that the decoder is able to parse all the headers and metadata, but some parts of the stream content (actual video) are malformed/incompatible. How often is that printed? I suppose it might have occurred before, but you didn’t see it because of the amount of non-existing PPS 0 referenced logs. Also, make sure that parameter sets are not duplicated - both provided to the decoder via options and forwarded there by the parser (the second way is the best solution imho).
Silencing logs may not be the best way to go, as they can possibly carry some useful information in case of failure.
0
ConnorRigby
Nerves Core Team
It prints it pretty constantly. I haven’t checked exactly but it looks like it happens on every frame. These logs weren’t here before i sent the sps and pps values to the parser. I’ll double check that it’s being sent/forwarded correctly.
0