Either product_id is nil or wrong?
andreaseriksson
shijith.k
I doubt its because I am using Ecto.Multi. Because multi dont create the product until all the functions run perfectly, right? Correct me if I am wrong
0
andreaseriksson
Sorry for the late answer but I changed the code to:
def tag_product(product, %{tag: tag_attrs} = attrs) do
tag = create_or_find_tag(tag_attrs)
product
|> Ecto.build_assoc(:taggings)
|> Tagging.changeset(attrs)
|> Ecto.Changeset.put_assoc(:tag, tag)
|> Repo.insert()
end
defp create_or_find_tag(%{name: "" <> name} = attrs) do
%Tag{}
|> Tag.changeset(attrs)
|> Repo.insert()
|> case do
{:ok, tag} -> tag
_ -> Repo.get_by(Tag, name: name)
end
end
defp create_or_find_tag(_), do: nil
And test:
test "tag_product/2 with valid data appends the tag if it exists" do
product = product_fixture()
tag = tag_fixture()
Taggable.delete_tag_from_product(product, tag)
assert {:ok, %Tagging{} = tagging} = Taggable.tag_product(product, %{tag: %{name: "Stout"}})
assert tagging.tag.name == "Stout"
end
0
shijith.k
I checked your GitHub code, and there is a cast_assoc in the taggings Changeset function, and in the tag_product function you have added another put_assoc too. Can you please explain me your code?
0
shijith.k
Also, this was because I used Task.async_stream to iterate over the list of tags and bind them to the product.
I changed it to Stream.map and now it works fine. Any idea, why Task.async_stream causes this error? @andreaseriksson
0
andreaseriksson
I tried to remove it but one of the test cases failed (raised) instead of returning an error changeset. But maybe that scenario would never happen if you design your UI correct
0
andreaseriksson
Im guessing since there are database constraints and you running the inserts async, the references are not persisted at this point? Or the current process doesn’t know about it.
0
andreaseriksson
@shijith.k Did everything work out for you?
I also added a second part where I have an interface for adding the tags:
0
shijith.k
Yes, everything worked out. But I didn’t use cast_assoc is taggings changeset.
I will check the second part of the tutorial.
If you dont mind, can we have a chat in slack or telegram? I have some doubts
0