Because of the backward compatibility. I can check out if that could be “fixed” by adding new module to ExUnit though. I will try to provide PR tomorrow (CET) unless you will do that first. You can ping me in PR if you want.
hauleth
Sebb
I’m just doing my first steps with Elixir, I can’t possibly create a PR for ExUnit. Most likely it would break all tests in the world.
btw there is a } missing in your code:
def log(log_event, %{config: %{pid: pid}}) do
- send(pid, {{__MODULE__, :log}, log_event)
+ send(pid, {{__MODULE__, :log}, log_event})
end
1
Sebb
there is a bug in the last version, it can’t handle complex data, this should be better, but most likely is still flawed.
# with log level :info
import PureLogger
assert [{:logger, :error, {4711, %{file: _, line: _}}}] = error(4711)
assert [{:logger, :error, {'test', %{file: _, line: _}}}] = error('test')
assert [{:logger, :error, {"test", %{file: _, line: _}}}] = error("test")
assert [{:logger, :error, {[1, 2, 3], %{file: _, line: _}}}] = error([1, 2, 3])
assert [{:logger, :error, {[a: 1, b: 2], %{file: _, line: _}}}] = error([a: 1, b: 2])
assert [{:logger, :error, {{1, 2}, %{file: _, line: _}}}] = error({1, 2})
assert [{:logger, :error, {{1, 2, 3}, %{file: _, line: _}}}] = error({1, 2, 3})
assert [{:logger, :error, {%{a: 1}, %{}}}] = error(%{a: 1, b: 2, c: 3})
assert [] = debug(%{a: 1, b: 2, c: 3})
defmodule PureLogger do
@levels [:emergency, :alert, :critical, :error, :warning, :notice, :info, :debug]
for level <- @levels do
defmacro unquote(level)(data) do
maybe_log(unquote(level), data, __CALLER__)
end
end
def maybe_log(level, data, caller) do
meta = Map.take(caller, [:file, :line])
if do_log?(level) do
quote do
[
{
:logger,
unquote(level),
{
unquote(data),
unquote(Macro.escape(meta))
}
}
]
end
else
[]
end
end
defp do_log?(level) do
min_level = Application.get_env(:toy, :log_min_level, :all)
:logger.compare_levels(level, min_level) == :gt
end
end
0