The compiler would certainly warn on the example above because “foo” is unused.
josevalim
Creator of Elixir
christhekeele
That’s true. I suppose the way to capture the anti-shadowing sentiment that this is bad practice would be:
def transform(results) do
results = if some_check(results) do
results = Enum.map(&something) #warning: variable used in inner scope shadows outer scope
use_and_return_interim_results(results)
else
[]
end
use_and_return_ulitimate_results(results)
end
Piping or renaming the variable would fix.
I don’t actually care much for this. It feels like such a warning should exist at the Credo level rather than the compiler, anyways.
0