No, thanks. But you can verify the solution. I give me some days, because I’m on vacation. Next week, I will commit in the master branch some updates, which should fix the issue with 4.0 and DocumentDB. If you verify, that the commits fix your issue, I will release a new version. Thanks for reporting this issue.
zookzook
fireproofsocks
zookzook
I committed a fix on the master branch. Feel free to test it. If it is working like expected, then I will draft a new release for the fix!
1
fireproofsocks
I’ve tested the master branch changes locally on Mongo 4.0 and on our production stack running DocumentDB and it works! I set log: true in my config – Mongo 4.0 complains a little with errors like:
17:18:25.177 application=db_connection module=DBConnection function=log_raised/4 [error] an exception was raised logging %DBConnection.LogEntry{call: :execute, connection_time: 5655000, decode_time: 21000, idle_time: 498146000, params: [], pool_time: 179000, query: %Mongo.Query{action: {:exec_hello, []}}, result: {:ok, %Mongo.Query{action: {:exec_hello, []}}, {%{"ismaster" => true, "localTime" => ~U[2022-10-11 21:18:25.189Z], "logicalSessionTimeoutMinutes" => 30, "maxBsonObjectSize" => 16777216, "maxMessageSizeBytes" => 48000000, "maxWireVersion" => 7, "maxWriteBatchSize" => 100000, "minWireVersion" => 0, "ok" => 1.0, "readOnly" => false}, %Mongo.Events.CommandStartedEvent{command: :hello, command_name: :hello, connection_id: #PID<0.535.0>, database_name: "admin", operation_id: nil, request_id: 2}, 0, 5565}}}: ** (BadFunctionError) expected a function, got: true
(db_connection 2.4.2) lib/db_connection.ex:1532: DBConnection.log/2
(db_connection 2.4.2) lib/db_connection.ex:1510: DBConnection.log/5
(mongodb_driver 0.9.2) lib/mongo.ex:1526: Mongo.exec_hello/2
(stdlib 3.16.1) timer.erl:166: :timer.tc/1
(mongodb_driver 0.9.2) lib/mongo/monitor.ex:239: Mongo.Monitor.get_server_description/1
(mongodb_driver 0.9.2) lib/mongo/monitor.ex:164: Mongo.Monitor.update_server_description/1
(mongodb_driver 0.9.2) lib/mongo/monitor.ex:151: Mongo.Monitor.handle_info/2
(stdlib 3.16.1) gen_server.erl:695: :gen_server.try_dispatch/4
But it works fine! Just like it did with 0.9.1.
On the DocumentDB instance, no errors are logged at all. So this is looking pretty good to me.
0
zookzook
zookzook
Ok, I think, you used the wrong log configuration from the DBConnection module:
* `:log` - A function to log information about a call, either
a 1-arity fun, `{module, function, args}` with `t:DBConnection.LogEntry.t/0`
But you should use:
config :mongodb_driver,
log: true
in your config file. I think, the logging issue in your example is cleared. I will provide a new release in the next few days.
0
fireproofsocks
Hmm… the error is there when log: true is passed as an option, e.g.
iex> Mongo.start_link([url: "mongodb://localhost:27017/my_dev", name: :my_mongo, log: true])
{:ok, #PID<0.338.0>}
iex(3)> [error] an exception was raised logging %DBConnection.LogEntry{call: :execute, connection_time: 3939000, decode_time: 1434000, idle_time: 2857000, params: [], pool_time: 19000, query: %Mongo.Query{action: {:exec_hello, []}}, result: {:ok, %Mongo.Query{action: {:exec_hello, []}}, {%{"ismaster" => true, "localTime" => ~U[2022-10-14 14:13:36.151Z], "logicalSessionTimeoutMinutes" => 30, "maxBsonObjectSize" => 16777216, "maxMessageSizeBytes" => 48000000, "maxWireVersion" => 7, "maxWriteBatchSize" => 100000, "minWireVersion" => 0, "ok" => 1.0, "readOnly" => false}, %Mongo.Events.CommandStartedEvent{command: :hello, command_name: :hello, connection_id: #PID<0.339.0>, database_name: "admin", operation_id: nil, request_id: 0}, 0, 3920}}}: ** (BadFunctionError) expected a function, got: true
(db_connection 2.4.2) lib/db_connection.ex:1532: DBConnection.log/2
(db_connection 2.4.2) lib/db_connection.ex:1510: DBConnection.log/5
(mongodb_driver 0.9.2) lib/mongo.ex:1526: Mongo.exec_hello/2
(stdlib 3.16.1) timer.erl:166: :timer.tc/1
(mongodb_driver 0.9.2) lib/mongo/monitor.ex:239: Mongo.Monitor.get_server_description/1
(mongodb_driver 0.9.2) lib/mongo/monitor.ex:164: Mongo.Monitor.update_server_description/1
(mongodb_driver 0.9.2) lib/mongo/monitor.ex:151: Mongo.Monitor.handle_info/2
(stdlib 3.16.1) gen_server.erl:695: :gen_server.try_dispatch/4
[metadata]
It’s referencing the master branch, commit d7c8652b4e66a0031e1a7fe36bc2af5c85cef408 is in the mix.lock. However, if I set the option in the config (instead of passing it as an option), I don’t get the error.
And to be thorough, here’s how I installed Mongo:
docker pull mongo:4.0.0
docker run -p 27017:27017 -d --name mongo mongo:4.0.0
However, this error has been there for a while (including in 0.9.1) and everything is working – I just never noticed the error because I had never enabled the :log option, and the message doesn’t appear when the same code connects to AWS DocumentDB. So it may not be worth trying to squash the error for older versions of Mongo. Or if the hello stuff is specific to different versions, then maybe the code could be isolated into its own module and overridden via config or something.
Thank you for making such a great package and for maintaining it so vigorously!
0
zookzook
All good! To make it clear: the log option is not part of the driver, it belongs to DBConnection, that is another package. You configure the logging in the config file.
1
fireproofsocks
zookzook
Currently, I’m working on some improvements like migration, the collection load and dump function. After this is done I will publish a new release.
0