That kinda depends on the usecase. I’ve seen people use seeds for both seeding of data for development purposes – so you’re not dealing with an empty app – as well as seeding the db with data, which the application depends on to function (properly) in the first place – hence needed for any environment. Those usecases have quite different constraints.
LostKobrakai
coen.bakker
fuelen
One tiny optimization could be applied with placeholders. Probably, it won’t be noticeable, but still good as an exercise.
5
riebeekn
Forget where I initially saw it, but another thing to consider which I often do is making enviro specific seed files so it is more apparent what their purpose is.
i.e. in mix.exs
"ecto.seed": ["run priv/repo/seeds.#{Mix.env()}.exs"]
and then you would have priv/repo/seeds.dev.exs, priv/repo/seeds.test.exs, and priv/repo/seeds.prod.exs files.
1
fuelen
mix is not available in prod
and I’m not sure what is the use-case for test env, as usually each test creates data it needs.
0
gregvaughn
I always take a second look at any line of code using Enum.each. In your case, the insert_all could be returning a result indicating that nothing was inserted, but it won’t be made visible because each always returns :ok
2
riebeekn
true, you have to run the seeds from release.ex in production if for instance using releases.
I found test env seeds can be useful in cases where you have slow set up tasks for data that doesn’t change. The specific case I ran into was using triplex to set up tenant schemas. But yeah, this is all pretty case specific so maybe not worth it in most instances.
0
coen.bakker
coen.bakker
Never seen this, but would seeds.demo.exs or demo_seeds.exs be helpful?
Using just seeds.exs for demo data seems too ambiguous or even misleading, based on this thread.
0
riebeekn
Honestly re-reading what you’re going for I’d probably just stick with the normal seeds file. If you want to control what enviros they get applied to here is another approach (and all around a good article on seeding): https://medium.com/geekculture/phoenix-understanding-how-to-seed-data-c2be863ddd1d
1