Hopefully not like the movie.
code-shoily
BartOtten
Scopes in the generators! Wonderful. This was an essential part I always had to put in a new project. Although I always called it ‘context’ so far.
Any particular reason for ‘scope’? Does the name not collide with scopes in Router which are a whole different thing?
Congrat to the team. We are spoiled 
Ps. It’s a long time since I used the generators. Since when do they auto subscribe to pubsub? Totally missed it 
4
AstonJ
I loved the film (though at the time had only seen the trailer). She ends up saving the world 
1
sodapopcan
“Context” collides with “Phoenix Contexts.” I otherwise agree that “context” is the “right” word.
The last project I worked on that used this pattern called it ApplicationContext which was a mouthful, especially since its instances were initally called current_application_context which is why I bothered ask the question I did up there.
2
hubertlepicki
felix-starman
I’ve seen current_scope used to mean the masquerade user, or when a person has access to multiple companies. Then their default company or original user is stored in some other way.
0
hubertlepicki
Congratulations on the release! Some feedback below you may find useful or not :).
I really like the layouts change. To be honest, I never understood the need for having two layouts and it’s been a source of confusion how to use it properly. I have been using a function components in exactly the same way you describe, being it a <MainComponent breadcrumbs=[...]>...</MainConponent> already for a good while, using Surface UI, this approach works great and is simple to understand.
I do like the addition of scopes too. I don’t love the naming, as mentioned above the “Context” would be better but that’s taken. The naming of Contexts I never loved either, they’re more of “namespaces” to me. I also don’t think they’re necessary at all, but that’s another story and you can just not use them. In addition the name of “scope” collides with similar concept in router, which maybe should be called something else as well. What are “scopes” in router seem to roughly map to “route_prefix” in scope definition itself: Scopes — Phoenix v1.8.0-rc.0. Naming is hard, ugh.
Having a “scope” container for key assigns like current_account and current_role is great, and it reduces friction, but you still have to pass it around from parent LV to children components and its components. But we now know that this is not an intended use case for components. Personally I really like how this is solved in Surface UI with it’s own concept Contexts, which is what many will be more familiar with from other frameworks.
The guide for scopes mentions it requires users to be familiar with introduction and up and running, but since third way through it uses concepts that the user will not be familiar with if all they know are these two guides. Specifically it goes on to describe use with LiveView, which the user will not be familiar at this stage. May be useful to have another banner above these sections that say the required understanding for that part of the guide is knowledge of LiveView.
Removal of CoreComponents is great, I’m glad to see them gone as it was a boilerplate code that I didn’t find useful. Less is more.
Passwordless authentication is awesome addition. I really like how the auth generators handled sign in so far, this is done very properly even as an educational tool, and can’t wait to try/see how passwordless auth is done.
4
BartOtten
It is not mentioned in the changelog afaik but 1.8 scopes also allow for basic localized routes. The elegant generic solution pleases my eyes and I am glad Phoenix will ship with it.
2
krasenyp
I really hope scopes grow to be used not only for the current user but also for general dependency injection. People need someone from above to tell them the mantra “protocols are for data” is completely meaningless. Let’s make the scope polymorphic and we’ll gain flexibility and better testability!
0
egze
I wonder if this would have been a better api Blog.get_post!(id, scope: socket.assigns.current_scope) with the scope being optional 
4