@matt-savvy I think the best thing from this point might actually be to make a small reproduction project that we can look at, and/or add some tests for this behavior to AshPhoenix.Form. Then we can just get it all fixed in one fell swoop, and maybe even write a guide on it 
zachdaniel
Creator of Ash
0
matt-savvy
I think the best thing from this point might actually be to make a small reproduction project that we can look at
Yup, I can extend the project I linked yesterday.
and/or add some tests for this behavior to
AshPhoenix.Form
I did try to do that, but since the test resources in AshPhoenix are all using the ETS data layer, I was running into some differences right away. Maybe I can give that another shot.
0
zachdaniel
Creator of Ash
matt-savvy
Too late, I think I got the tests showing the issue
https://github.com/ash-project/ash_phoenix/pull/385
LMK if this is clear.
0
zachdaniel
Creator of Ash
zachdaniel
Creator of Ash
Okay, so, I’ve modified the tests you provided a bit. Ultimately I think what you want to do here is not use the include_non_map_types? option. It is a bit of a red herring actually.
Ultimately, the argument is disconnected from the underlying value in this kind of update, so I think you want to fill out the options yourself.
Something like this:
# form
form = AshPhoenix.Form.for_update(task, :update, as: "task")
# render
<.input
field={@form[:contexts]}
value={Enum.map(@form.source.source.data.contexts, &(&1.id))}
type="select"
multiple
label="Contexts"
options={@contexts |> Enum.map(fn opt -> {opt.name, opt.id} end)}
/>
0
matt-savvy
That seems to do the trick!
# render
<.input
field={@form[:contexts]}
value={form_context_value(@form)}
type="select"
multiple
label="Contexts"
options={@contexts |> Enum.map(fn opt -> {opt.name, opt.id} end)}
/>
# elsewhere
defp form_context_value(form) do
case form.source.source.data.contexts do
%Ash.NotLoaded{} -> [] # needed for the for_create form
contexts -> Enum.map(contexts, & &1.id)
end
end
0
matt-savvy
Oh snap, just saw that. Happy to help, wasn’t really expecting that to land on main. So I’m assuming the related code change actually just prevents the BadMapError.
Thanks for all the help digging into this issue. At this point, I think I at least have a little better understanding, so I’ll probably tinker with my code and see if there seems to be an easy way to set this up so that we don’t need to manually transform the changeset data to get the values.
1
matt-savvy
Actually, just found one issue with this approach …
Changing any other field triggers the validation. So if I’ve updated the context, and then I make any other change, the contexts get reset.
For example, load a task that belongs to context 1 and 2 → update the context so it’s only 2 → update the status field → validation triggered, resetting the context to 1 and 2 (the original values).
0
zachdaniel
Creator of Ash
Ah, sorry you’re right, we need to handle the changing value.
# elsewhere
defp form_context_value(form) do
case Ash.Changeset.fetch_argument(form.source.source, :contexts) do
{:ok, context_ids} -> context_ids
:error ->
case form.source.source.data.contexts do
%Ash.NotLoaded{} -> [] # needed for the for_create form
contexts -> Enum.map(contexts, & &1.id)
end
end
end
0