I would say it would be weird for a multiline map to look like this:
%{
id_counter: id,
nodes: insert_node(document.nodes, node)
}
and then we don’t have a newline after %{ for updates.
josevalim
Creator of Elixir
2
mischov
That’s reasonable. I had never formatted them like either syntax before, and preferred:
%{document |
id_counter: id,
nodes: insert_node(document.nodes, node)}
But if you’re moving the braces onto their own lines I guess the formatter is logically consistent. Looks weird, but I’m sure I’ll get used to it.
1
josevalim
Creator of Elixir
I also preferred the previous approach but I found I was in the minority. So you are not the only one getting used to it. 
2
mischov
I just remember seeing (RE: the formatter):
There is actually a counter-example where the development happened behind “closed doors”. This was a deliberate decision because style discussions can be quiet opinionated and heated.
So I assume the discussion exists somewhere- is it ever likely to be made public for the purpose of answering questions like mine?
Also, is formatting types from another module with parens (String.t as String.t()) just a matter of consistency? I think it might be one of the most common changes I’ve seen.
0
OvermindDL1
I tend to prefer:
%{document|
id_counter: id,
nodes: insert_node(document.nodes, node),
}
There is only ever something after a multi-line map starting token of %{ if it is updating, and that line ends with |, no spaces, then each line is a single key/value pair, always ending with a , for easy moving around and copy/pasting or so, then finally a line with just a } by itself. It is a pattern I’ve used from other languages that have similar map/dict updating styles. ^.^
EDIT: And non-updating syntax I use the same without the part after the %{, like:
%{
id_counter: id,
nodes: insert_node(document.nodes, node),
}
5
josevalim
Creator of Elixir
mischov
I love Rust’s adoption of the trailing comma for that reason- so much easier to modify. It never seemed particularly idiomatic to put it in Elixir code, though.
4
mischov
This one made me chuckle (because parens are usually added).
defp not_(b) when is_boolean(b), do: not(b)
reformated to
defp not_(b) when is_boolean(b), do: not b
I guess not has special formatting?
1
josevalim
Creator of Elixir
not is a unary operator, so it follows the logic of other unary operators (which is no parens). For instance, you write +foo, not +(foo).
0
mischov
Maybe not always a huge win for readability.
Before:
@document Meeseeks.Parser.parse(
{"html", [], [
{"head", [], []},
{"body", [], [
{"div", [], [
{"p", [], ["1"]},
{"p", [], ["2"]},
{"div", [], [
{"p", [], ["3"]},
{"p", [], ["4"]}]},
{"p", [], ["5"]}]}]}]})
After:
@document Meeseeks.Parser.parse({
"html",
[],
[
{"head", [], []},
{
"body",
[],
[
{
"div",
[],
[
{"p", [], ["1"]},
{"p", [], ["2"]},
{"div", [], [{"p", [], ["3"]}, {"p", [], ["4"]}]},
{"p", [], ["5"]}
]
}
]
}
]
})
Edit: Just want to clarify I’m not trying to be negative about the formatter- I love it! I think it will help the community greatly. A big thank you to those people involved in working on it.
1