Hey there, I am working with a client for an OpenAPI spec, and I have a dilemma.
Imagine the following
defmodule API.Account do
@moduledoc """
Implements /account endpoints.
"""
alias StrawHat.Response
alias API.{Client, Client.Request}
@type t :: %__MODULE__{
email: String.t(),
id: String.t(),
is_international: boolean()
}
defstruct [:email, :id, :is_international]
@doc """
Retrieve account information.
"""
@spec get_account(%Client{}) :: Response.t(%__MODULE__{}, Client.error())
def get_account(client) do
client
|> Request.new()
|> Request.put_method(:get)
|> Request.put_path("/account")
|> Client.send()
|> StrawHat.Response.and_then(&transform_response/1)
end
@doc false
def new(data) do
%__MODULE__{
email: data["email"],
id: data["id"],
is_international: data["isInternational"]
}
end
defp transform_response(data) do
data
|> new()
|> Response.ok()
end
end
Here is my dilemma: Should I transform the incoming data into structs, or I shouldn’t bother with it?
I am talking about the following part
|> StrawHat.Response.and_then(&transform_response/1)
Should I keep that? Or should I just return the raw data?
I still don’t know what the right answer is here honestly.
From one side, it is a lot of work and I think doesn’t matter much, not sure.
From the otherwise, it is nice, I get to have structs and normalize a bit the keys and such.