kingdomcoder

kingdomcoder

I have a set of custom validations and changes that are tightly coupled together.

Imagine a create action:

...
validate check_something_about(:forms, extra_param)
change do_something_to(:forms, extra_param)
...

What is the “Ash” way of approaching this?

Should the validations and the changes be separated out (as in the example above) or should it all happen in the change, leveraging Ash.Changeset.add_error/3 to report errors?

Thanks.

Showing Posts 1 to 1

zachdaniel

zachdaniel

Creator of Ash

Its an interesting question. What exactly makes them coupled? Are you expecting to reuse this combination in the future? There are a few ways to do it:

Call validations from the change

You could combine it by calling the validations in the change. If you have a reusable validation that you want wrapped into a bigger change.

with :ok <- Validation.validate(changeset, ...),
        :ok <- OtherValidation.validate(changeset, ...) do

end

Macro it

You could define a macro that includes both:

defmacro check_and_validate(key, param) do
  quote do
    check_something_aboute(:forms, extra_param)
    do_something_to(:forms, extra_param)
  end
end

And then in the action

create :create do
  change_and_validate(:forms, extra_param)
end

Share functionality with functions

If they are coupled in terms of functionality, then you could define a module with functions in it that allow them to share this functionality.

def change(changeset, _, _) do
  SharedBehavior.foo(changeset)
end

def validate(changeset, _) do
  SharedBehavior.foo(changeset)
end

Put it all in the change

At the end of the day, its perfectly acceptable to do a “validation” inside of a change, returning an error as you mentioned. Change modules are meant to be that outlet when their simpler counterpart, validations, don’t suffice.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
psy-q
I’m trying to set up Emacs with elixir-ls via lsp-mode and credo via Flycheck. This should mostly be preconfigured as Flycheck picks up c...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews