kamaroly

kamaroly

Ash is not running `before_action` hook callback function when updates are atomic

Ash is not triggering before_action hook’s callback function if the update action is atomic, but when I set require_atomic? false in the action, Ash calls thecallback function (request_approval/3) as expected.

The create action works well. I am not sure why the update action is not working as expected on the atomic updates. What could I be getting wrong?

Below is my change:

defmodule MyApp.Changes.SubmitForApproval do
  use Ash.Resource.Change

  @impl Ash.Resource.Change
  def change(%{context: %{changes_approved?: true}} = changeset, _opts, _context) do
    # Changes have been approved, proceed to persist in the datalayer as expected.
    changeset
  end

  def change(changeset, opts, context) do
    # Changes are yet to be approved, seek approval before persisting them in the database

    # !!! ========================================!!!
    # Atomic updates are not firing request_approval/3 function.
    # !!! ========================================!!!
    Ash.Changeset.before_action(changeset, &request_approval(&1, opts, context))
  end

  @impl Ash.Resource.Change
  def atomic(changeset, opts, context) do
    {:ok, change(changeset, opts, context)}
  end

  defp request_approval(changeset, opts, context) do
    # ================================================
    # !!! THIS IS NOT REACHED WHEN UPDATES ARE ATOMIC !!!
    # ================================================
    # 1. Serialize the changeset
    # 2. Store the change request for approval 
    # 2. Prevent submitting to underlying datalayer until approved
   changeset
  end
end

Most Liked Switch mode

zachdaniel

zachdaniel

Creator of Ash

Atomic update actions do not support before action hooks. We should be adding an error there instead of skipping them though.

Last Post!

kamaroly

kamaroly

The goal is to implement a maker-checker mechanism to changes.

Here is how I do it. It works for create but not for updates.

  1. Intercept database changes(create, update and delete).
  2. Serialize changeset to binary and store it in the change_requests table.
  3. Notify the approver to review the newly submitted changes in change request.
  4. If approved, convert stored changes from binary to term and make changes in the DB.
  5. Otherwise, ignore changes.

Where Next?

Trending in Questions Top

jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
saveman71
Hello ! We want new/edit form pages to POST/PUT to their own URL rather than the resources REST defaults (post /things, put /things/:id)...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement