kamaroly

kamaroly

Ash is not triggering before_action hook’s callback function if the update action is atomic, but when I set require_atomic? false in the action, Ash calls thecallback function (request_approval/3) as expected.

The create action works well. I am not sure why the update action is not working as expected on the atomic updates. What could I be getting wrong?

Below is my change:

defmodule MyApp.Changes.SubmitForApproval do
  use Ash.Resource.Change

  @impl Ash.Resource.Change
  def change(%{context: %{changes_approved?: true}} = changeset, _opts, _context) do
    # Changes have been approved, proceed to persist in the datalayer as expected.
    changeset
  end

  def change(changeset, opts, context) do
    # Changes are yet to be approved, seek approval before persisting them in the database

    # !!! ========================================!!!
    # Atomic updates are not firing request_approval/3 function.
    # !!! ========================================!!!
    Ash.Changeset.before_action(changeset, &request_approval(&1, opts, context))
  end

  @impl Ash.Resource.Change
  def atomic(changeset, opts, context) do
    {:ok, change(changeset, opts, context)}
  end

  defp request_approval(changeset, opts, context) do
    # ================================================
    # !!! THIS IS NOT REACHED WHEN UPDATES ARE ATOMIC !!!
    # ================================================
    # 1. Serialize the changeset
    # 2. Store the change request for approval 
    # 2. Prevent submitting to underlying datalayer until approved
   changeset
  end
end

Showing Posts 1 to 4

zachdaniel

zachdaniel

Creator of Ash

Atomic update actions do not support before action hooks. We should be adding an error there instead of skipping them though.

kamaroly

kamaroly OP

Thanks @zachdaniel. Is there a way to set require_atomic? false globally on specific resources?

What I want is that if ash_approval extension is added to a resource, the atomic updates should be disabled conditionally based on whether changes have been approved or not.

zachdaniel

zachdaniel

Creator of Ash

I’m pretty sure you can’t do that at all. The whole concept of atomicity in Ash is about “not reading the record before updating it”. Could you describe more of what you’re trying to accomplish? How is approval stored and how is it checked?

kamaroly

kamaroly OP

The goal is to implement a maker-checker mechanism to changes.

Here is how I do it. It works for create but not for updates.

  1. Intercept database changes(create, update and delete).
  2. Serialize changeset to binary and store it in the change_requests table.
  3. Notify the approver to review the newly submitted changes in change request.
  4. If approved, convert stored changes from binary to term and make changes in the DB.
  5. Otherwise, ignore changes.
— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
psy-q
I’m trying to set up Emacs with elixir-ls via lsp-mode and credo via Flycheck. This should mostly be preconfigured as Flycheck picks up c...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews