Onek

Onek

Ash Policies and AshJsonApi

Hopefully a simple one where I’m just not understanding the documentation properly between policies and AshJsonAPI.

I have a resource with two attributes where we use one of the attributes to reference a value that is held in our Actor struct. Note our “user” isn’t captured as a resource in Ash and we’re instead ad-hoc creating the Actor struct in a plug further up the pipeline.

attribute :name, :string
attribute :owner_id, :string

This resource is exposed via AshJsonAPI and I’d like to put some access restrictions on the :create, :update, and :destroy actions where clients shouldn’t be allowed to create, update, or destroy records that they don’t “own”.

policy action_type([:update, :destroy]) do
   forbid_unless expr(owner_id == ^actor(:name))
end

This seemingly works, however it returns a 404 instead of a 403 when a policy isn’t allowed for :update and :destroy. I’m not sure if that’s expected or not, but I thought :update and :destroy would yield the forbidden error rather than the “filtering” 404. Further, if I update the :access_type to force :strict mode then the policy never authorizes anything even when the expr should be returning true (this one definitely confuses me). For a little more context the :read action is unrestricted so anyone can see anyone else’s records – they’re just not allowed to update/delete them.

policy action_type([:update, :destroy]) do
   access_type :strict
   authorize_if expr(owner == ^actor(:name))
end

Trying to figure out if I’m missing something, if the above behavior is an actual bug, or maybe I’m playing way out in left field somewhere.

Marked As Solved

zachdaniel

zachdaniel

Creator of Ash

filtering updates

There are actually two “modes” for authorizing bulk updates and destroys. AshJsonApi uses Ash.bulk_update and Ash.bulk_destroy with a filter for a single record as a mechanism for potentially avoiding the need to update the underlying record. It is currently using the default behavior, which adds the authorization rules for the update as a filter. We could make this configurable, telling AshJsonApi to pass authorize_changeset_with: :error (this is not supported by all data layers, but postgres can do it). This would give you the behavior you are looking for. Please open a proposal issue or PR :person_bowing:. We can likely add a domain-wide and/or global configuration to start, which would be pretty straightforward.

access_type :strict

As to why access_type :strict doesn’t behave as expected, what access_type :strict means is that “everything in this policy must pass before ever attempting to speak to the data layer”. its effectively impossible to use a filter check in that context. You could instead write custom checks that do things like look at the changeset and compare changing values to the actor etc.

Last Post!

zachdaniel

zachdaniel

Creator of Ash

Yep, you should prefer to use SimpleCheck, and add def requires_original_data?(_, _), do: true to the check module.

Where Next?

Popular in Questions Top

lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
mcarvalho
What is the difference between System.get_env and Application.get_env? For example, what are best practices to use one versus another.
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New
fireproofsocks
Forgive me if this is obvious, but how does one delete a database record WITHOUT selecting it first? Ecto.Repo — Ecto v3.14.0 has exampl...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New

Other popular topics Top

KronicDeth
Elixir plugin for JetBrain’s IntelliJ Platform (including Rubymine) This is a plugin that adds support for Elixir to JetBrains IntelliJ...
289 36820 110
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
joaquinalcerro
Hi there, I am working with Ecto-Postgresql and I need to call all of the records from a specific table but the table has 40,000 records...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod – where is this set? Thanks.
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New

We're in Beta

About us Mission Statement