amos-kibet

amos-kibet

Ash Policies: `nil` is not a Spark DSL module

I have a FilterCheck policy that looks like this:

use Ash.Policy.FilterCheck

 def filter(actor, context, options) do
    tenant_id = context.subject.tenant.id

    resource_name =
      options[:resource]
      |> to_string()
      |> String.split(".")
      |> List.last()

    expr(
      exists(
        MyApp.AccessRight,
        tenant_id == ^tenant_id and
          resource_name == ^resource_name and read == true)
      )
    )

    # dbg()
  end

and I use this policy in my resource this way:

  policies do
    policy action(:list_paginated) do
      authorize_if MyFilterCheckPolicy
    end
  end

and here is how I use the resource action in my LiveView:

Posts.list_paginated(actor: current_user, tenant: tenant)

The problem:
For some reason, this setup does not work; it raises this error:

[error] ** (ArgumentError) `nil` is not a Spark DSL module.

    nil.persisted(:data_layer)
    (spark 2.2.31) lib/spark/dsl/extension.ex:138: Spark.Dsl.Extension.persisted!/3
    (ash 3.4.21) lib/ash/filter/filter.ex:3734: Ash.Filter.do_hydrate_refs/2
    ... more stacktraces below

and interestingly, it works if I uncomment the dbg() call at the end of the policy (see code above).

How can I fix the above error?

First 6 of 6 Posts Switch mode

zachdaniel

zachdaniel

Creator of Ash

exists does not take a resource it takes a relationship or relationship oath.

i.e exists(access_rights, ....

or

exists(access_rights.user, ...

Please open an issue describing that bad error output and I will look to make it clearer.

almirsarajcic

almirsarajcic

Thanks for the response.

I’m working together with Amos on this, so I just want to provide more context.

The reason why we put the module name there was we tried to use the tenant relationship, instead of relationship to the record policy is affecting. We’re trying to use the same policy for several types of resources that don’t have direct relationship to access_rights.

Is it possible to get the tenant from the context, and then get access_rights rows associated with it plus filter based on some additional conditions?

I’ve tried this but it didn’t work.

def filter(actor, context, options) do
  tenant =
    case context.query.tenant do
      %Tenant{} = tenant ->
        tenant

      _ ->
        tenant_id = String.replace(context.query.tenant, "tenant_", "")
        Ash.get!(Tenant, tenant_id)
    end

  resource_name =
    options[:resource]
    |> to_string()
    |> String.split(".")
    |> List.last()

  expr(
    exists(
      ^tenant.access_rights,
      resource_name == ^resource_name and
        read == true and
        exists(group.group_users, user_id == ^actor.id)
    )
  )
end
zachdaniel

zachdaniel

Creator of Ash

:thinking: You should be able to do something along those lines, yes. When you say it didn’t work, what do you mean?

almirsarajcic

almirsarajcic

I’ve had the same error.

I’ll try two things: manual relationships vs using lower-level Ash.Query functions and post the result.

zachdaniel

zachdaniel

Creator of Ash

Ah, sorry I just looked more closely. You can’t use exists with anything other than a relationship reference. ^value is not a relationship reference.

Here is the related issue for the improvement we’d like to make. Support resources as aggregate targets in expressions · Issue #939 · ash-project/ash · GitHub

So to do this logic that you want you’ll need to do the work entirely in the check module. and return {:ok, true | false}

almirsarajcic

almirsarajcic

Since I needed to do a filter check instead of a simple check, I ended up with a manual relationship and with more knowledge about the powers of Ash. Mind getting blown every day… :exploding_head:

Thanks!

— All posts loaded —

Where Next?

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement