Guy14

Guy14

AshJsonApi.Error translations

Hello community!

Yesterday I tried for a while to translate errors that comes from AshJsonApi controllers (which are AshJsonApi.Error structs, often built from other error structs such as Ash.Error.Changes.InvalidAttribute if I understood well).

What I used to achieve is to take precedence on AshJsonApi errors implemented in the lib, with dumb errors just for the try, such as this one:

defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Changes.InvalidAttribute do
  def to_json_api_error(error) do
    dbg("HERE")

    %AshJsonApi.Error{
      id: Ash.UUID.generate(),
      status_code: AshJsonApi.Error.class_to_status(error.class),
      code: "panic",
      title: "Panic",
      detail: error.message
      meta: Map.new(error.vars)
    }
  end
end

But the tradoffs of this new implementation are:

  • I get a compiler warning:

    warning: redefining module AshJsonApi.ToJsonApiError.Ash.Error.Changes.InvalidAttribute (current version loaded from _build/dev/lib/ash_json_api/ebin/Elixir.AshJsonApi.ToJsonApiError.Ash.Error.Changes.InvalidAttribute.beam)│16 │ defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Changes.InvalidAttribute do│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~│└─ lib/prepair/to_ash_json_api_error.ex:16: AshJsonApi.ToJsonApiError.Ash.Error.Changes.InvalidAttribute (module)
    
  • I will lost eventual updates on the own library errors implementation

  • I do not manage to translate the error message with gettext (no compiler errors / warnings, but the displayed error is not yet the custom one I wrote, so it shows there is a problem in my implementation of the AshJsonApi.ToJsonApiError protocol):

    defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Changes.InvalidAttribute do
      use Gettext, backend: PrepairWeb.Gettext
    
      def to_json_api_error(error) do
        dbg("HERE")
    
        %AshJsonApi.Error{
          id: Ash.UUID.generate(),
          status_code: AshJsonApi.Error.class_to_status(error.class),
          code: "panic",
          title: "Panic",
          detail:
            dgettext(
              "errors",
              "must have the @ sign and no spaces"
            ),
          meta: Map.new(error.vars)
        }
      end
    end
    

I’ve searched on solutions but haven’t found one for now. The nearest to my problem thread I’ve read is this one: Translating Ash Error messages but I haven’t found a solution in it.

Does some of you already implemented translations for AshJsonApi errors?

To add more context, I can say for instance that this translations does work for AshErrors (not AshJsonApi) displayed in the Phoenix Liveview frontend:

defmodule Prepair.ValidationMacros do
  defmacro validate_email() do
    quote do
      use Gettext, backend: PrepairWeb.Gettext

      validate match(
                 :email,
                 ~S/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+.[a-zA-Z0-9-.]+$/
               ) do
        on [:create, :update]
        message dgettext("errors", "must have the @ sign and no spaces")
      end

But I wonder why the AshJsonApi error which comes from the Ash error triggered by that validation doesn’t send a translated error to the API.

Marked As Solved

zachdaniel

zachdaniel

Creator of Ash

I’ve pushed to main an improvement to mirror what we have with ash_graphql, which is an error_handler configuration you can set on each domain that would let you intercept and translate errors.


For gettext, you can’t use it in the DSL like that unfortunately. Those values are captured at compile time.

Also Liked

Guy14

Guy14

Just to let you know, it works perfectly for my needs!!

Thanks a lot again :orange_heart: And the added doc for Errors is well detailed :ok_hand:

And to anyone reading this post later, here is the solution, thanks to the new feature Zach added, that I’m using to translate API errors coming from AshJsonApi (generated) controllers:

# accounts.ex (Ash Domain)

defmodule Prepair.Accounts do
  use Ash.Domain, extensions: [AshJsonApi.Domain]

  json_api do
    routes do
      ...
    end

    error_handler {PrepairWeb.JsonApiErrorHandler, :handle_error, []}
  end
# json_api_error_handler.ex

defmodule PrepairWeb.JsonApiErrorHandler do
  use Gettext, backend: PrepairWeb.Gettext

  def handle_error(error, _context) do
    translated_detail = translate_error_detail(error.detail)
    %{error | detail: translated_detail}
  end

  defp translate_error_detail(detail) when is_binary(detail) do
    Gettext.dgettext(PrepairWeb.Gettext, "errors", detail)
  end

  defp translate_error_detail(detail), do: detail
end

Where Next?

Popular in Questions Top

RisingFromAshes
I’ve read in another post that it may be possible with a router helper - but I couldn’t find an appropriate one, and tbh, I’m still just ...
New
New
hariharasudhan94
lets say i have a sample like a = 20; b = 10; if (a > b) do {:ok, "a"} end if (a < b) do {:ok, b} end if (a == b) do {:ok, "equa...
New
jerry
Good day to you all. I have been struggling to get a query involving like and ilike to work. Can anyone assist me on this, please? pro...
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
romenigld
I am trying to run a deploy with docker and I successfully runned with this command: docker build -t romenigld/blog-prod . but when I t...
New
fayddelight
I tried installing elixir 1.11.2 erlang 23.3.4 via asdf in my zsh shell. Enabled the versions locally and globally. When I list them ...
New

Other popular topics Top

KronicDeth
Elixir plugin for JetBrain’s IntelliJ Platform (including Rubymine) This is a plugin that adds support for Elixir to JetBrains IntelliJ...
289 36820 110
New
minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
grych
Hi folks, Few months ago I have announced the proof-of-concept of the library to manipulate the browsers DOM objects directly from Elixi...
639 54260 488
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New
romenigld
I am trying to run a deploy with docker and I successfully runned with this command: docker build -t romenigld/blog-prod . but when I t...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New

We're in Beta

About us Mission Statement