Guy14

Guy14

Hello community!

Yesterday I tried for a while to translate errors that comes from AshJsonApi controllers (which are AshJsonApi.Error structs, often built from other error structs such as Ash.Error.Changes.InvalidAttribute if I understood well).

What I used to achieve is to take precedence on AshJsonApi errors implemented in the lib, with dumb errors just for the try, such as this one:

defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Changes.InvalidAttribute do
  def to_json_api_error(error) do
    dbg("HERE")

    %AshJsonApi.Error{
      id: Ash.UUID.generate(),
      status_code: AshJsonApi.Error.class_to_status(error.class),
      code: "panic",
      title: "Panic",
      detail: error.message
      meta: Map.new(error.vars)
    }
  end
end

But the tradoffs of this new implementation are:

  • I get a compiler warning:

    warning: redefining module AshJsonApi.ToJsonApiError.Ash.Error.Changes.InvalidAttribute (current version loaded from _build/dev/lib/ash_json_api/ebin/Elixir.AshJsonApi.ToJsonApiError.Ash.Error.Changes.InvalidAttribute.beam)│16 │ defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Changes.InvalidAttribute do│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~│└─ lib/prepair/to_ash_json_api_error.ex:16: AshJsonApi.ToJsonApiError.Ash.Error.Changes.InvalidAttribute (module)
    
  • I will lost eventual updates on the own library errors implementation

  • I do not manage to translate the error message with gettext (no compiler errors / warnings, but the displayed error is not yet the custom one I wrote, so it shows there is a problem in my implementation of the AshJsonApi.ToJsonApiError protocol):

    defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Changes.InvalidAttribute do
      use Gettext, backend: PrepairWeb.Gettext
    
      def to_json_api_error(error) do
        dbg("HERE")
    
        %AshJsonApi.Error{
          id: Ash.UUID.generate(),
          status_code: AshJsonApi.Error.class_to_status(error.class),
          code: "panic",
          title: "Panic",
          detail:
            dgettext(
              "errors",
              "must have the @ sign and no spaces"
            ),
          meta: Map.new(error.vars)
        }
      end
    end
    

I’ve searched on solutions but haven’t found one for now. The nearest to my problem thread I’ve read is this one: Translating Ash Error messages but I haven’t found a solution in it.

Does some of you already implemented translations for AshJsonApi errors?

To add more context, I can say for instance that this translations does work for AshErrors (not AshJsonApi) displayed in the Phoenix Liveview frontend:

defmodule Prepair.ValidationMacros do
  defmacro validate_email() do
    quote do
      use Gettext, backend: PrepairWeb.Gettext

      validate match(
                 :email,
                 ~S/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+.[a-zA-Z0-9-.]+$/
               ) do
        on [:create, :update]
        message dgettext("errors", "must have the @ sign and no spaces")
      end

But I wonder why the AshJsonApi error which comes from the Ash error triggered by that validation doesn’t send a translated error to the API.

Showing Posts 1 to 3

zachdaniel

zachdaniel

Creator of Ash

I’ve pushed to main an improvement to mirror what we have with ash_graphql, which is an error_handler configuration you can set on each domain that would let you intercept and translate errors.


For gettext, you can’t use it in the DSL like that unfortunately. Those values are captured at compile time.

Guy14

Guy14 OP

Hi Zach, thanks a lot for this solution, that sounds great, I’ll give it a try on tomorrow evening :slight_smile:

Guy14

Guy14 OP

Just to let you know, it works perfectly for my needs!!

Thanks a lot again :orange_heart: And the added doc for Errors is well detailed :ok_hand:

And to anyone reading this post later, here is the solution, thanks to the new feature Zach added, that I’m using to translate API errors coming from AshJsonApi (generated) controllers:

# accounts.ex (Ash Domain)

defmodule Prepair.Accounts do
  use Ash.Domain, extensions: [AshJsonApi.Domain]

  json_api do
    routes do
      ...
    end

    error_handler {PrepairWeb.JsonApiErrorHandler, :handle_error, []}
  end
# json_api_error_handler.ex

defmodule PrepairWeb.JsonApiErrorHandler do
  use Gettext, backend: PrepairWeb.Gettext

  def handle_error(error, _context) do
    translated_detail = translate_error_detail(error.detail)
    %{error | detail: translated_detail}
  end

  defp translate_error_detail(detail) when is_binary(detail) do
    Gettext.dgettext(PrepairWeb.Gettext, "errors", detail)
  end

  defp translate_error_detail(detail), do: detail
end

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
rlipscombe
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
rlipscombe
When I use Mix.install with a git dependency, using git@github.com:... how do I change the SSH identity used? I’ve got two Github accoun...
New
adr
Hello all. I have a question as to best practices for code organization when implementing a liveview with a lot of responsibilities. Sup...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
raa-ziq
Hi everyone :waving_hand: I wanted to share something I’ve been building — NowBlind, a random chat app designed to help people discover ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New
kip
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews