boblancer

boblancer OP

Hi
Wanted opinion about what would be the best practice to enforce auto formatting in CI pipeline

I was thinking that I could run mix format and commit it repo before merge

First 3 of 3 Posts Switch mode

lucaong

lucaong

One simple way is to run mix format --check-formatted as a check on the CI pipeline, so that it would fail if the code is not properly formatted. Here you can see an example with GitHub Action on my CubDB project. The action is run for every pull request as part of the build.

I often include the same check as a pre-push Git hook, so I get informed of format issues even before I push my code.

Note that this won’t fix the format issues, but rather just inform about them and cause the pipeline to fail. It is also possible to auto-fix the format and push a new commit, but I normally prefer not to, as it opens up possible issues with concurrent pipelines.

Sebb

Sebb

I do the checks in a pre-commit hook

#!/bin/sh

mix format --check-formatted
if [ $? -ne 0 ]; then exit 1; fi

mix credo --strict > /dev/null
if [ $? -ne 0 ]; then mix credo --strict; exit 1; fi

mix dialyzer > /dev/null
if [ $? -ne 0 ]; then mix dialyzer; exit 1; fi

mix test --warnings-as-errors > /dev/null
if [ $? -ne 0 ]; then mix test --warnings-as-errors; exit 1; fi
kwando

kwando

I don’t want CI to “rewrite” my code, but I’m all for a mix format --check-formatted step in CI :slight_smile:

— All posts loaded —

Where Next? Top

Trending in Discussions Top

AstonJ
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
2977 91898 914
New
AstonJ
The obligatory hello world thread! Who are you and where are you from? :stuck_out_tongue:
4616 55835 594
New
byu
@chrismccord : I just saw the Extract AGENTS.md from Phoenix.new into phx.new generator commit to the phoenix project. My initial shotgu...
New
arcanemachine
I was working on an Ecto migration and I needed a timestamp. So, for the nth time, I looked up the different data types for timestamps, a...
New
AstonJ
Just a general thread to post chat/news/info relating to AI/ML stuff that may be relevant for Nx now or in the future. Got anything to sh...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New

Other Trending Topics Top

AstonJ
Curious what kind of hardware people are using with <span class="hashtag-icon-placeholder"></span>beam-bots - if you’re building somethin...
New
JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New

We're in Beta

About us Mission Statement