smangelsdorf

smangelsdorf

I’ve encountered some unusual behavior from Dialyzer while validating values from Application.get_env and reduced it down to the following code with a deliberately incorrect typespec (should be list(module()) on the return):

  @spec actually_a_list_of_modules(list(term())) :: list(DateTime.t())
  def actually_a_list_of_modules(list) when is_list(list) do
    validate_modules(list)
    list
  end

  defp validate_modules(modules), do: Enum.each(modules, &ensure_valid_module/1)

  defp ensure_valid_module(a) when is_atom(a), do: :ok
  defp ensure_valid_module(a), do: raise("Not a module: #{inspect(a)}")

Dialyzer accepts this without complaint, and I’m not sure why. When I change the validate_modules function to destructure the list manually, Dialyzer complains as expected:

  # This implementation fixes the problem, and Dialyzer correctly shows an error.
  defp validate_modules([]), do: nil

  defp validate_modules([a | b]) do
    ensure_valid_module(a)
    validate_modules(b)
  end

I also tried implementing this with a comprehension to see if something specific to Enum.each was affecting the type checking, but it behaves in the same way as the first example.

  # This is incorrectly accepted, the same as the Enum.each version.
  defp validate_modules(modules), do: for(m <- modules, do: ensure_valid_module(m))

I understand this could just be a limitation of Dialyzer, and I’m happy to refactor my code accordingly. I’d love to know what’s causing this behaviour, though. Why’s Dialyzer getting confused?

(Reproduced on Elixir 1.16.3 + Erlang/OTP 26.2 and also Elixir 1.14.3 + Erlang/OTP 25.3)

Showing Posts 1 to 3

sabiwara

sabiwara

Elixir Core Team

Dialyzer is unfortunately clueless about protocols in general and Enumerable in particular.

It also doesn’t have the notion of generics: Function.identity/1 will basically do type-laundering and its output will just end up being a term (instead of preserving the type of the input).

I understand this could just be a limitation of Dialyzer

Indeed, this is a limitation of Dialyzer’s success typing, this great article can help set up the right expectations and avoid expecting it to behave like a static type system.

smangelsdorf

smangelsdorf OP

Thanks, that’s useful. Am I correct in thinking that for comprehensions are desugared into Enum calls, and that’s why it has the same behaviour?

sabiwara

sabiwara

Elixir Core Team

Indeed you are correct!

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews