mxst
Can I have a devstruct with computed values?
Hey everyone.
I was wondering about how I should initialize a struct where I have some values and some computed values.
For now I came up with:
defmodule Stats do
defstruct annotations: 0, true_positive: 0,
false_positive: 0, false_negative: 0,
precision: 0, recall: 0
def set_precision(stats \\ %AnnotationStats{}) do
Map.put(stats, :precision, (stats.true_positive / (stats.true_positive + stats.false_positive)))
end
def set_recall(stats \\ %AnnotationStats{}) do
Map.put(stats, :recall, (stats.true_positive / (stats.true_positive + stats.false_negative)))
end
end
What I the initialize with
my_stats = %Stats{annotations: 3, true_positive: 1, false_positive: 2, false_negative: 1}
|> set_precision()
|> set_recall()
But is there a cleaner way ? Or the way to do it?
Thank you all ![]()
Marked As Solved
Eiji
Here is my proposition:
defmodule Stats do
required_keys = [:false_negative, :false_positive, :true_positive]
@enforce_keys required_keys
defstruct required_keys ++ [annotations: 0, precision: 0, recall: 0]
@type t :: %__MODULE__{
annotations: integer,
false_negative: integer,
false_positive: integer,
precision: float,
recall: float,
true_positive: integer
}
@spec init(t) :: t
def init(%__MODULE__{true_positive: true_positive} = struct) do
computed = %{
precision: init_computed(true_positive, struct.false_positive),
recall: init_computed(true_positive, struct.false_negative)
}
Map.merge(struct, computed)
end
defp init_computed(true_positive, value), do: true_positive / (true_positive + value)
end
Stats.init(%Stats{annotations: 3, false_negative: 1, false_positive: 2, true_positive: 1})
It would fail if you did not pass 3 keys (specified in @enforce_keys) which are required to compute.
Alternatively you could write something like:
defmodule Stats do
required_keys = [:false_negative, :false_positive, :true_positive]
@enforce_keys required_keys
defstruct required_keys ++ [annotations: 0, precision: 0, recall: 0]
@type t :: %__MODULE__{
annotations: integer,
false_negative: integer,
false_positive: integer,
precision: float,
recall: float,
true_positive: integer
}
@spec init(map, integer, integer, integer) :: t
def init(map, false_negative, false_positive, true_positive) do
full_map =
map
|> Map.put(:false_negative, false_negative)
|> Map.put(:false_positive, false_positive)
|> Map.put(:precision, init_computed(true_positive, false_positive))
|> Map.put(:recall, init_computed(true_positive, false_negative))
|> Map.put(:true_positive, true_positive)
struct(__MODULE__, full_map)
end
defp init_computed(true_positive, value), do: true_positive / (true_positive + value)
end
This way allows to pass map (don’t require struct), but forces to pass required keys separately.
Finally you can also do it in more pattern-matching like way:
defmodule Stats do
required_keys = [:false_negative, :false_positive, :true_positive]
@enforce_keys required_keys
defstruct required_keys ++ [annotations: 0, precision: 0, recall: 0]
@type init_map :: %{
optional(:annotations) => integer,
optional(:precision) => float,
optional(:recall) => float,
required(:false_negative) => integer,
required(:false_positive) => integer,
required(:true_positive) => integer
}
@type t :: %__MODULE__{
annotations: integer,
false_negative: integer,
false_positive: integer,
precision: float,
recall: float,
true_positive: integer
}
@spec init(init_map) :: t
def init(
%{
false_negative: false_negative,
false_positive: false_positive,
true_positive: true_positive
} = map
) do
computed = %{
precision: init_computed(true_positive, false_positive),
recall: init_computed(true_positive, false_negative)
}
__MODULE__ |> struct(map) |> Map.merge(computed)
end
defp init_computed(true_positive, value), do: true_positive / (true_positive + value)
end
Which allows to pass required keys in map.
2
Popular in Questions
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible.
total = 10
while total != 0
...
New
What is the difference between System.get_env and Application.get_env? For example, what are best practices to use one versus another.
New
Hello all!
I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
I’m working on defining a simple Ecto schema for a table (in PostGres), but I don’t see where I can define a column as NOT NULL. Conside...
New
Hello, I have map which I want to convert it to string like this:
the map:
%{last_name: "tavakkoli", name: "shahryar"}
the string I ne...
New
What’s the safe way to decode a JSON string into a struct? I want to avoid calling String.to_atom. Jason.decode can give me a map with st...
New
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum.
...
New
I’ve got an issue with an app and I’ve no idea of how to troubleshoot it. I’m hoping someone here might have seen something similar.
I p...
New
I would like to know what is the best IDE for elixir development?
New
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New
Other popular topics
I am constructing a JSON object (map) and I need to conditionally set a field. I’m trying to write proper elixir-way code… and I’m at a l...
New
As promised, the first release candidate of Phoenix 1.3.0 is out! This release focuses on code generators with improved project structure...
New
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: )
Hello all, this is ...
New
Good day to you all.
I have been struggling to get a query involving like and ilike to work.
Can anyone assist me on this, please?
pro...
New
i’m a new one to elixir
which editor can i use
vs code? or atom?
Thanks! :smiley:
New
I have VueJS GUIs with the project generated using Webpack.
I have Elixir modules that will need to be used by the VueJS GUIs.
I forese...
New
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum.
...
New
I am going through the kafka architecture. All the features what the kafka is providing are already in Erlang. I would like hear your opi...
New
I would like to know what is the best IDE for elixir development?
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #javascript
- #code-sync
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance









