chocolatedonut

chocolatedonut

Can this error be caught by a tool (mix compile, Dialyzer, etc.)?

TL;DR
A single element, in this case an integer, is given to a Phoenix.Component but a list of such elements should be given. Can a compile-time warning/error be produced by any tool?

I’ve made a repro project. The gist of it is that

  1. A.Foo returns an integer to
  2. AWeb.ALive and it in turn (incorrectly) forwards this integer (rather than a list of integers) to
  3. AWeb.AComponent.
#1
defmodule A.Foo do
  @spec number() :: pos_integer()
  def number() do
    1729
  end
end

#2
defmodule AWeb.ALive do
  use AWeb, :live_view

  def mount(_params, _session, socket) do
    {:ok,
     socket
     |> assign(:number, A.Foo.number())}
  end

  def render(assigns) do
    ~H"""
    <AWeb.AComponent.bar numbers={@number} />  # Should've been `[@number]`
    """
  end
end

#3
defmodule AWeb.AComponent do
  use Phoenix.Component

  attr(:numbers, :list, required: true)

  @spec bar(%{numbers: list(pos_integer)}) :: any
  def bar(assigns) do
    ~H"""
    <li :for={number <- @numbers}>
      <%= number %>
    </li>
    """
  end
end

Can this be catched by the compiler, Dialyzer, anything? My understanding is “no”, but I hope I’m wrong:

  • attr macro atm only does compile-time validation of literals
  • even @specing the Phoenix.Component above with @spec bar(%{numbers: list(pos_integer)}) :: any doesn’t help, as mix dialyzer gives no warnings.

Is there any other tool that would help with this?

Most Liked

jeremyjh

jeremyjh

I haven’t looked at the implementation of the heex compiler, but my intuition suggests there is a runtime apply happening versus compiling a direct invocation of the function in the component syntax. If that is the case then there is no static link between the bar function and its invocation. I do not know if that is a detail that can be changed, but I’d start there and at least rule out the possibility that could be done to support dialyzer.

Where Next?

Popular in Questions Top

New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New
sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
bsollish-terakeet
Credo is smart enough to check for (something like) this: assert length(the_list) == 0 with this response: Checking if an enum is empt...
New
freewebwithme
Using vs code and installed ElixirLS: support and debugger. And I got an error popped up on start up says Failed to run ‘elixir’ comma...
New
SoCreat
i’m a new one to elixir which editor can i use vs code? or atom? Thanks! :smiley:
New

Other popular topics Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
grych
Hi folks, Few months ago I have announced the proof-of-concept of the library to manipulate the browsers DOM objects directly from Elixi...
639 54006 488
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
openscript
Hello! Sorry for this astonishing simple question, but I’m really stuck. I try to set up the intellij-elixir plugin, but I don’t know ho...
New
chrismccord
Phoenix 1.4.0 released Phoenix 1.4 is out! This release ships with exciting new features, most notably with HTTP2 support, improved deve...
688 31494 112
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New

We're in Beta

About us Mission Statement