axelson

axelson

Scenic Core Team

I often use ExUnit.CaptureLog to capture information about a log message. But it doesn’t give you any information about the logged metadata. I’ve been adding structured logging recently and I’d like to assert that my code is correctly emitting the correct structured logs, but ExUnit.CaptureLog doesn’t keep or return the metadata. How have others solved this? Maybe we could create a PR to ex_unit that would add a function that returns the metadata along with the captured message?

Showing Posts 1 to 3

al2o3cr

al2o3cr

At first glance, seems like the tricky part would be getting the results back to what’s calling capture_log - the current code uses a StringIO after formatting the event:

https://github.com/elixir-lang/elixir/blob/f6856cf8015e567866a5d0ab0f993209a488ff33/lib/ex_unit/lib/ex_unit/capture_server.ex#L230-L237

RudManusachi

RudManusachi

Hi, Jason :wave: !

In one project I format logs in json and include metadata there in the message, so it’s pretty straight forward.. (Jason.decode the captured log and assert on internals).

However, I guess that’s not your case, so I think we could add :logger handler and try to assert on the metadata within log_event.
Since handlers run in the same process as the one that emits the log we could send the log_event to self() and receive in test roughly something like this:

defmodule LoggerTestHelper do
  def log(log_event, config) do
    send(config.test_pid, {:logged_event, log_event})
  end
end

defmodule Test do
  use ExUnit.Case, async: true
  require Logger

  setup do
    :logger.add_handler(:test_handler, LoggerTestHelper, %{test_pid: self()})
    on_exit(fn -> :logger.remove_handler(:test_handler) end)
  end

  test "metadata" do
    Logger.info("hello", foo: :bar)

    assert_receive {:logged_event, %{meta: meta} = _log_event}
    assert meta.foo == :bar
  end
end

UPD: I just realized, that event might be logged by a process other than the test itself, and sending log_event to self() is quite limiting… Hence, I updated the example passing test_pid to logger handler config and having it to send log_event to test_pid explicitly.

axelson

axelson OP

Scenic Core Team

Hi Rudolf! :wave:

Oooh, I didn’t expect adding a handler within the test to end up that straightforward and clean! I’ve marked your answer as the solution because it does indeed solve the problem, thank you!

I’ve also extended your example helper slightly to improve the ergonomics, mainly so that it’s easy to get all the logged messages that match a given string, and to return a formatted version of the string (although I’m sure that there’s other cases that would be needed besides {:string, iolist} if this were to hit production:

defmodule LoggerTestHelper do
  def log(log_event, config) do
    message =
      case log_event.msg do
        {:string, iolist} -> to_string(iolist)
      end

    send(config.test_pid, {:logged_event, message, log_event})
  end

  def logs_containing_string(search_string) do
    {:messages, all_messages} = :erlang.process_info(self(), :messages)

    for {:logged_event, message, log_event} <- all_messages,
        String.contains?(message, search_string) do
      {message, log_event}
    end
  end
end

And here’s my example test:

test "logs with metadata", %{conn: conn} do
  {_result, _log} =
    ExUnit.CaptureLog.with_log(fn ->
      conn = get(conn, ~p"/posts")
      assert html_response(conn, 200) =~ "Listing Posts"
    end)

  assert [{message, log}] =
           LoggerTestHelper.logs_containing_string("Sent 200 for GET /posts")

  assert message =~ "2 queries executed in"
  assert message =~ "2 logs captured"

  assert log.meta.method == "GET"
  assert log.meta.request_path == "/posts"
  assert log.meta.duration
  assert log.meta.total_queries == 2

  for query <- log.meta.ecto_queries do
    assert query =~ "FROM \"posts\""
  end
end

If you’re curious about the content of the test I’ve been playing with the ideas of Wide Logs (or Canonical Logs) that are captured quite well in this Stripe blog post:

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews