jeffdeville
In iex, this I can do this:
quote do
unquote(%{})
end
And get the expected:
%{}
But for some reason, in the macro I’m working on, I’m getting: invalid quoted expression: %{}
defmodule ExModbus do
defmacro __using__(_options) do
quote do
Module.register_attribute __MODULE__, :fields, accumulate: true, persist: false
require Logger
import unquote(__MODULE__), only: [field: 6, field: 7, to_bytes: 2, map_enum_value: 2]
@before_compile unquote(__MODULE__)
end
end
defmacro __before_compile__(env) do
compile(Module.get_attribute(env.module, :fields))
end
###########################
changing the default enum_map from to %{} results in the error
###########################
defmacro field(name, type, addr, num_bytes, perms, desc, enum_map \ %{}) do
quote bind_quoted: [name: name, type: type, addr: addr,
num_bytes: num_bytes, perms: perms, desc: desc, enum_map: enum_map] do
@fields {name, type, addr, num_bytes, perms, desc, enum_map}
end
end
def compile(fields) do
ast = for {name, type, addr, num_bytes, perms, desc, enum_map} <- fields do
getter_ast = defgetter(name, type, addr, num_bytes, desc, enum_map)
case perms do
:r -> getter_ast
:rw -> [defsetter(String.to_atom("set_" <> Atom.to_string(name)), type, addr, desc) | [getter_ast] ]
end
end
quote do
def field_defs(), do: @fields
unquote(ast)
end
end
def to_bytes(data, :int16), do: <<data::signed-integer-size(16)>>
def to_bytes(data, :uint16), do: <<data::unsigned-integer-size(16)>>
def to_bytes(data, :enum16, map), do: <<Map.get(map, data, data)::unsigned-integer-size(16)>>
def defgetter(name, type, addr, num_bytes, desc, enum_map) do
quote do
@doc """
# Description:
#{unquote(desc)}
* Field Type: #{unquote(type)}
"""
# @spec unquote(name)(pid, integer) :: unquote(map_type(type))
def unquote(name)(pid, slave_id \\ 1) do
with {:ok,
%{data: {:read_holding_registers, data},
transaction_id: transaction_id,
unit_id: unit_id}} <- ExModbus.Client.read_data(pid, slave_id, unquote(addr - 1), unquote(num_bytes)),
{:ok, value} <- ExModbus.Types.convert_type(data, unquote(type)),
{:ok, value} <- map_enum_value(unquote(enum_map), value)
do
{:ok, %{data: value, transaction_id: transaction_id, slave_id: unit_id}}
else
{:type_conversion_error, {data, type}} -> {:type_conversion_error, {data, type}}
{:enum_not_found_error, message} -> {:enum_not_found_error, message}
end
end
end
end
def defsetter(name, type, addr, desc) do
quote do
@doc """
# Description:
#{unquote(desc)}
* Field Type: #{unquote(type)}
"""
def unquote(name)(pid, slave_id, data) do
case ExModbus.Client.write_multiple_registers(pid, slave_id, unquote(addr - 1), to_bytes(data, unquote(type))) do
{:ok, %{data: {:write_multiple_registers, data}, transaction_id: transaction_id, unit_id: unit_id}} ->
{:ok, %{data: data, transaction_id: transaction_id, slave_id: unit_id}}
other ->
IO.puts inspect other
end
end
end
end
def map_enum_value([], value), do: {:ok, value}
def map_enum_value(nil, value), do: {:ok, value}
def map_enum_value(enum_map, value) do
Map.get(enum_map, value, {:enum_not_found_error, "#{inspect enum_map} either has no member #{value}, or it is out of range"})
end
end
Any thoughts as to why this might be? (also, if there’s a way to stitch this AST together a little better, please feel free to illuminate me!
Trending in Questions
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
Hello,
I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
So my question is quite simple and i have found no conclusive answer on forum, google or AI.
Should we use :erlang.float for Integer to ...
New
Documentation
While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
Other Trending Topics
I am happy to introduce the very α version of the new programming language compiled to BEAM.
Welcome Cure.
It has literally three kille...
New
Hi there! We created Gust: A task orchestrator inspired by Airflow.
For those who have never heard about Aiflow, it’s a Python-based wor...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself.
My main conc...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixirconf-us
- #ai
- #blog-post
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #hex
- #security
- #metaprogramming











Showing Posts 1 to 2- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
josevalim
quote and unquote work on ASTs and maps are not valid ASTs. If you want to inject values, such as maps, tuples with any element and so on into an AST, you need to escape the value with
Macro.escape/1.jeffdeville
Perfect! Thank you @josevalim
In case anyone needs a working (if convoluted, and needing refactor) example later: