GenericJam

GenericJam

Cleaner alternative for nested case/cond/if statements?

I’m trying to find a cleaner coding style for what I’ve got happening repeatedly in my code right now. This is looking very pyramid of doom-ish

# Variables in scope
%{ var1: var1, var2: var2, var3: var3}
case function1(var1) do
    # Success case one
    {:ok, %{pattern1: _}} ->
      case function2(var2) do
        {:ok, %{pattern2: _}} ->
          # Etc with the nesting as need be
          Logger.info()

        other ->
          Logger.error("Oops")
      end

    # Success case two
    {:ok, %{pattern3: _}} ->
      case function3(var2) do
        {:ok, %{pattern4: _}} ->
          # Etc with the nesting as need be
          Logger.info()

        other ->
          Logger.error("Oops")
      end

    # Failure case
    other ->
      Logger.error("He's dead, Jim. Cause of death: #{inspect(other)}")
  end

I know that as an alternative I could put the pattern matching/fail catching in a series of functions but this isn’t necessarily any more readable as the functions should be grouped by name not by logical association. Once the logic gets more complicated, it is actually worse imo for readability.

Is there some alternative I’m missing?

First Post! Switch mode

preciz

preciz

Most Liked

cnck1387

cnck1387

Just for future searches, would you mind including the with version so we have a before and after?

GenericJam

GenericJam OP

Here’s a rough translation although not direct as in the original I’ve got two success cases where only the first one will match whereas in the translation both with (potentially) match. This is the general idea though:

%{var1: var1, var2: var2, var3: var3}

    with {:ok, %{pattern1: _}} <- function1(var1),
          # Now you can use pattern1
         {:ok, %{pattern2: _}} <- function2(%{pattern1: pattern1, var2: var2}) do
      # Etc with the nesting as need be
      Logger.info()
    else
      # Failure case
      other ->
        Logger.error("He's dead, Jim. Cause of death: #{inspect(other)}")
    end

    with {:ok, %{pattern3: _}} <- function1(var1),
         {:ok, %{pattern4: _}} <- function3(var2) do
      # Etc with the nesting as need be
      Logger.info()
    else
      # Failure case
      other ->
        Logger.error("He's dead, Jim. Cause of death: #{inspect(other)}")
    end

Where Next?

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement