Code reloading in `lib/<appname>` no longer works with 1.7.0-rc.0

Try mix deps.compile file_system

It fixed the issue with live reload, for me, after I updated both Mac and Phoenix.

Unfortunately this had no effect. On the second machine I tried this on there was no elixir (or really any devtools at all) beforehand. Completely clean install of erlang/elixir/phoenix 1.7 rc0

Worth clarifying, also, that I’m not talking about ‘live reload’, but just basic code reloading like editing the generated user.ex from phx.gen.auth. Changing the code does not cause the server to reload this code so it just keeps running the old version (e.g. add require Logger and Logger.error("TEST") to user.ex while the server is running, and you will not see the log (or at least, I don’t).

You might check the live reload patterns in config/dev.exs ans adjust them…

This post might be helpful.

Thanks but again that is for live reload, when I’m talking about just basic code reloading. As in the Phoenix server knowing that you edited an elixir file and using the new version. Nothing at all to do with browser reloading

If anyone would like to try to reproduce:

mix archive.install hex phx_new 1.7.0-rc.0
mix phx.new testapp && cd testapp
mix phx.gen.auth Accounts User users
mix deps.get && mix ecto.create && mix ecto.migrate
mix phx.server

Go to register a user and put in only 4 chars for password, say. You get a validation error as expected. Now go to lib/testapp/accounts/user.ex and add to validate_email function or similar, something like:

require Logger
Logger.error("\n\n\n*******************\nTESTING\n*************\n\n\n")

Hit submit button again in browser. I do not see my new log. Change text of log, hit button again – still no log. Restart the server and try again, log appears! Edit the log message again, hit button again, log text does not change.

I can say I have the same problem

Well that’s… ‘good’?
Thanks for confirming!

Can you clarify whether or not you are using LiveView based authentication system? When you run mix phx.gen.auth Accounts User users, you are given the prompt:

An authentication system can be created in two different ways:
- Using Phoenix.LiveView (default)
- Using Phoenix.Controller only
Do you want to create a LiveVIew based authentication system? [Yn]

I can only assume that you are using LiveView and if that’s the case, I think I know why your changes to your user.ex file aren’t being reflected. If you check endpoint.ex, you can see that plug Phoenix.CodeReloader is specified. So every request to your dev server goes through this plug and runs Phoenix.CodeReloader.reload(ExampleWeb.Endpoint) for you. If you were to make your logger change and reload the page, this ought to work and your change honoured.

Now, this doesn’t work with LiveView since they are process based. Once your LiveView connection is mounted (as in your LV has successfully mounted in both calls), all changes will be pushed to the LV, and won’t go through the Phoenix.CodeReloader. You would need to update something your web directory, or run recompile in your iex session.

I am not absolutely sure that this is the case, but give it a go without LV and see if you can replicate the issue you have.

Did you lodge a git issue, as I think this would be good to have fixed before final release.

I couldn’t see it here, but maybe its already closed.

Yea, this is an interesting point. It is a liveview auth system. However having worked with liveview before I’ve never had a code reloading problem like this. I’m going to try it with a non-live auth right now – uno momento.

Sadly an out-of-the-box non-liveview auth system seems to fail on the register page with no "new" html template defined for TestappWeb.UserRegistrationHTML (similar for the login page).

Anyway, simply the fact that you see stuff like:

Rebuilding...
Done in 48ms.

when editing in <appname>_web and not in <appname> seems like a problem to me.

@Rugged yea I had considered doing that right off the bat, but also I tend to assume it’s me doing something wrong by default were you able to confirm this behaviour yourself by any chance?