ImNotAVirus

ImNotAVirus

Hello, everyone.
I’d like to get your opinion on a pull-request that I just did: Feature: packet documentation by ImNotAVirus · Pull Request #1 · elvengard-mmo/elvengard_network · GitHub

I am currently working on a toolkit to facilitate game server development. Unfortunately, since I don’t know anyone who can review me in Elixir, it is difficult for me to improve and evaluate the quality of my code.

The purpose of this PR is to make a decorator system to define an internal documentation for macros.
The system looks like this:

@desc "Some description for my macro"
my_macro "Name" do
    @desc "Some description for a field"
    field :name, :type

    field :name2, :type2, description: "Some description for another field"
end

Based on the same system as Absinthe, I was able to generate corresponding structures that I store in a module attribute. Once this is done, I generate a function (elven_get_packet_documentation) that will return the module attribute which contains an array of documentation structures.

So I would like to know if anyone would feel in the mood to do a little review of this PR by posting a few comments (on Github and here if possible :stuck_out_tongue: ).

For the most motivated people, why not a general review of the project.

Thank you in advance.

PS: I just made a Git rebase onto master. It added a lot of unnecessary things to the understanding of the PR. Sorry

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
csmr
Hi all, I’m new here and would like to hear peoples views on my Elixir/Phoenix based game-engine! :smiley: Mutonex gamedesign was finish...
New
Stef-Verniers
Hello I’ve been coding in Elixir for almost two years now because of my current job where we implemented Elixir in our application. But ...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New
kip
In 2021 I started a new library called Tempo with the objective of modelling time as a set of intervals - not as instants. In 2022 I gave...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews