Fl4m3Ph03n1x

Fl4m3Ph03n1x

Background

Let’s say I have a TypedStruct that has some common fields:

typedstruct do
    @typedoc "A product."

    field(:item_id, String.t())
    field(:name, String.t())
    field(:brand, String.t())
  end

This is a product and because products can go on sale, I have another TypedStruct:

typedstruct do
    @typedoc "A sale."

    field(:item_id, String.t())
    field(:name, String.t())
    field(:brand, String.t())
    field(:price, number)
    field(:discount, boolean)
  end

Issue

Now, you are probably seeing there is some duplication here. Since a sale is a product with extra info, some of the fields are replicated.

A first attempt at a solution could be something like this:

typedstruct do
    @typedoc "A sale."

    field(:product, Product.t())
    field(:price, number)
    field(:discount, boolean)
  end

However, my use case does not allow for this. I must have a struct with exactly the same fields as Product.t() and a few extra. I cannot simply smash a product field into my sales struct.

Question

  • Is there a way to compose types using TypedStruct (or normal structs?)
  • If not, what do you think would be the solution with the least amount of copy/pasting for this issue?

Showing Posts 1 to 6

tcoopman

tcoopman

Are you saying a sale contains a product (1)? Or is a sale something completely different from a product(2)?

If (2): They’re not the same so don’t try to do as if they’re the same.
In case of (1): I’m really interested as for why you can’t do what you proposed with product as part of sale?

Fl4m3Ph03n1x

Fl4m3Ph03n1x OP

I would go for (1). A sale is not a product, but contains one.
I can’t follow the proposed solution because the generated Json file would not be compatible with the API I am integrating with.

tcoopman

tcoopman

I think the cleanest solution would be to write a custom encoder for the product: Jason.Encoder — jason v1.4.5

Although I would not mind this kind of duplication either.

It really depends on the domain and what sale and products are exactly.

LostKobrakai

LostKobrakai

That sounds like you‘re missing a translation layer between your internal data model and the outside world.

Fl4m3Ph03n1x

Fl4m3Ph03n1x OP

Yes, that is the thing I am trying to build :smiley:
Would you go for duplication, for an implementation of the Jason encode protocol, or something else?

LostKobrakai

LostKobrakai

I’d go for the simplest to change option for things outside of your control, which would likely be duplication. Don’t try to abstract something other people are in charge off.

— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews