axelclark

axelclark

Controller Test with Pow

I’ve added Pow into my project for authentication. Now I’m trying to update the tests Phoenix generated when I created my contexts.

I’ve added all my resource routes to the protected pipeline.

I used Pow.Plug.assign_current_user/3 to add a current user to my conn.

    test "redirects to show when data is valid", %{conn: conn} do
      user = %Golf.Accounts.User{email: "test@example.com", id: 1}
      conn = Pow.Plug.assign_current_user(conn, user, [])

      conn = post(conn, Routes.course_path(conn, :create), course: @create_attrs)

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

      conn = get(conn, Routes.course_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"
    end

My assertions about the create action all pass.

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

However, the final show action

      conn = get(conn, Routes.course_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"

fails because it gets redirected to the new_session path:

     ** (RuntimeError) expected response with status 200, got: 302, with body:
     <html><body>You are being <a href="/session/new?request_path=%2Fcourses">redirected</a>.</body></html>

If I reuse the original conn after I assign the current user, but before the create action, my tests pass.

    test "redirects to show when data is valid", %{conn: conn} do
      user = %Golf.Accounts.User{email: "test@example.com", id: 1}
      new_conn = Pow.Plug.assign_current_user(conn, user, [])

      conn = post(new_conn, Routes.course_path(new_conn, :create), course: @create_attrs)

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

      conn = get(new_conn, Routes.course_path(new_conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"
    end

Can someone help me out with how I need to update my tests?

Thanks!

Axel

Marked As Solved

danschultzer

danschultzer

Pow Core Team

Your second example is the way to go. This could also be done in a setup macro like so:

    setup %{conn: conn} do
      user = %Golf.Accounts.User{email: "test@example.com", id: 1}
      authed_conn = Pow.Plug.assign_current_user(conn, user, [])

      {:ok, conn: conn, authed_conn: authed_conn}
    end

    test "redirects to show when data is valid", %{authed_conn: authed_conn} do
      conn = post(authed_conn, Routes.course_path(authed_conn, :create), course: @create_attrs)

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

      conn = get(authed_conn, Routes.course_path(authed_conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"
    end

It’s because of how phoenix recycles connections in tests. The response conn will have a :state key set to :sent so when it’s reused the test helpers in Phoenix will build a new connection and only copy over headers e.g. cookies. Assigns will not be preserved.

Also Liked

danschultzer

danschultzer

Pow Core Team

Yeah, you would only ever need to do that if you are testing the session controller itself. Assigning :current_user is sufficient for all other controllers/routes.

juanma1331

juanma1331

Fixed. Had to recycle the conn manually.

test "redirects to show when data is valid", %{authed_conn: conn} do
      conn = post(conn, Routes.product_path(conn, :create), product: @create_attrs)
      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.product_path(conn, :show, id)

      conn = recycle_conn(conn) <-- Added

      conn = get(conn, Routes.product_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Product"
    end
defp recycle_conn(conn) do
    saved_assigns = conn.assigns
    conn =
      conn
      |> recycle()
      |> Map.put(:assigns, saved_assigns)
    conn
  end

All the tests are passing now, but i have defined the recycle_conn function on the controller_test, what if i want to test another authed controller? Need to redefine again, or create another helper module and define it there to ease reuse.
Im pretty new to elixir/phoenix and web dev in general. Sorry for my english

Last Post!

juanma1331

juanma1331

Fixed. Had to recycle the conn manually.

test "redirects to show when data is valid", %{authed_conn: conn} do
      conn = post(conn, Routes.product_path(conn, :create), product: @create_attrs)
      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.product_path(conn, :show, id)

      conn = recycle_conn(conn) <-- Added

      conn = get(conn, Routes.product_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Product"
    end
defp recycle_conn(conn) do
    saved_assigns = conn.assigns
    conn =
      conn
      |> recycle()
      |> Map.put(:assigns, saved_assigns)
    conn
  end

All the tests are passing now, but i have defined the recycle_conn function on the controller_test, what if i want to test another authed controller? Need to redefine again, or create another helper module and define it there to ease reuse.
Im pretty new to elixir/phoenix and web dev in general. Sorry for my english

Where Next?

Popular in Questions Top

electic
Hi, I am new to Elixir. I am trying to use the DateTime component to insert a date into MySQL however the there seems to be no way to fo...
New
minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod – where is this set? Thanks.
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
Lily
In templates/appointment/index.html.eex: &lt;%= for appointment &lt;- @appointments do %&gt; &lt;tr&gt; &lt;td&gt;&lt;%= appoi...
New
marius95
Hello everyone, I try to use an Javascript Event Handler in my root.html.leex file. Therefore I created a function in the app.js file: ...
New

Other popular topics Top

lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
joeerl
Hello again - after a longish gap I’ve decided I really must dig into Elixir and see what’s been happening here - so I have a few questio...
New
sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 49134 226
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New

We're in Beta

About us Mission Statement