axelclark

axelclark

Controller Test with Pow

I’ve added Pow into my project for authentication. Now I’m trying to update the tests Phoenix generated when I created my contexts.

I’ve added all my resource routes to the protected pipeline.

I used Pow.Plug.assign_current_user/3 to add a current user to my conn.

    test "redirects to show when data is valid", %{conn: conn} do
      user = %Golf.Accounts.User{email: "test@example.com", id: 1}
      conn = Pow.Plug.assign_current_user(conn, user, [])

      conn = post(conn, Routes.course_path(conn, :create), course: @create_attrs)

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

      conn = get(conn, Routes.course_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"
    end

My assertions about the create action all pass.

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

However, the final show action

      conn = get(conn, Routes.course_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"

fails because it gets redirected to the new_session path:

     ** (RuntimeError) expected response with status 200, got: 302, with body:
     <html><body>You are being <a href="/session/new?request_path=%2Fcourses">redirected</a>.</body></html>

If I reuse the original conn after I assign the current user, but before the create action, my tests pass.

    test "redirects to show when data is valid", %{conn: conn} do
      user = %Golf.Accounts.User{email: "test@example.com", id: 1}
      new_conn = Pow.Plug.assign_current_user(conn, user, [])

      conn = post(new_conn, Routes.course_path(new_conn, :create), course: @create_attrs)

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

      conn = get(new_conn, Routes.course_path(new_conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"
    end

Can someone help me out with how I need to update my tests?

Thanks!

Axel

Marked As Solved

danschultzer

danschultzer

Pow Core Team

Your second example is the way to go. This could also be done in a setup macro like so:

    setup %{conn: conn} do
      user = %Golf.Accounts.User{email: "test@example.com", id: 1}
      authed_conn = Pow.Plug.assign_current_user(conn, user, [])

      {:ok, conn: conn, authed_conn: authed_conn}
    end

    test "redirects to show when data is valid", %{authed_conn: authed_conn} do
      conn = post(authed_conn, Routes.course_path(authed_conn, :create), course: @create_attrs)

      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.course_path(conn, :show, id)

      conn = get(authed_conn, Routes.course_path(authed_conn, :show, id))
      assert html_response(conn, 200) =~ "Show Course"
    end

It’s because of how phoenix recycles connections in tests. The response conn will have a :state key set to :sent so when it’s reused the test helpers in Phoenix will build a new connection and only copy over headers e.g. cookies. Assigns will not be preserved.

Also Liked

danschultzer

danschultzer

Pow Core Team

Yeah, you would only ever need to do that if you are testing the session controller itself. Assigning :current_user is sufficient for all other controllers/routes.

juanma1331

juanma1331

Fixed. Had to recycle the conn manually.

test "redirects to show when data is valid", %{authed_conn: conn} do
      conn = post(conn, Routes.product_path(conn, :create), product: @create_attrs)
      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.product_path(conn, :show, id)

      conn = recycle_conn(conn) <-- Added

      conn = get(conn, Routes.product_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Product"
    end
defp recycle_conn(conn) do
    saved_assigns = conn.assigns
    conn =
      conn
      |> recycle()
      |> Map.put(:assigns, saved_assigns)
    conn
  end

All the tests are passing now, but i have defined the recycle_conn function on the controller_test, what if i want to test another authed controller? Need to redefine again, or create another helper module and define it there to ease reuse.
Im pretty new to elixir/phoenix and web dev in general. Sorry for my english

Last Post!

juanma1331

juanma1331

Fixed. Had to recycle the conn manually.

test "redirects to show when data is valid", %{authed_conn: conn} do
      conn = post(conn, Routes.product_path(conn, :create), product: @create_attrs)
      assert %{id: id} = redirected_params(conn)
      assert redirected_to(conn) == Routes.product_path(conn, :show, id)

      conn = recycle_conn(conn) <-- Added

      conn = get(conn, Routes.product_path(conn, :show, id))
      assert html_response(conn, 200) =~ "Show Product"
    end
defp recycle_conn(conn) do
    saved_assigns = conn.assigns
    conn =
      conn
      |> recycle()
      |> Map.put(:assigns, saved_assigns)
    conn
  end

All the tests are passing now, but i have defined the recycle_conn function on the controller_test, what if i want to test another authed controller? Need to redefine again, or create another helper module and define it there to ease reuse.
Im pretty new to elixir/phoenix and web dev in general. Sorry for my english

Where Next?

Popular in Questions Top

JeremM34
Hello, how can I check the Phoenix version ? Thanks !
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
hariharasudhan94
I would like to know what is the best IDE for elixir development?
New
skosch
To my knowledge, put_in, Map.update etc. all have the one limitation of not automatically creating intermediate keys when needed (for exa...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
PeterCarter
There are pre-rolled solutions for other frameworks that do work. However, Phoenix does not seem to have these. Have people had good expe...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New

Other popular topics Top

JeremM34
Hello, how can I check the Phoenix version ? Thanks !
New
hariharasudhan94
Lets say I have map like this fetching from my database %{"_id" =&gt; #BSON.ObjectId&lt;58eb1a7a9ad169198c3dXXXX&gt;, "email" =&gt; ...
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 49134 226
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New

We're in Beta

About us Mission Statement