prateek1192

prateek1192

Creating a supervisor with multiple children

I am trying to take an input from the user and then creating the number of genservers as input and Supervise them. My code is something like

defmodule GossSim do
  use Supervisor

def main(args) do
  # Since it is a mix generated project I had to put the main
  Supervisor.start_link(__MODULE__, args)
end

def start_link(args) do
  Supervisor.start_link(__MODULE__, args)
end

#The two methods down below create children dynamically
def get_child_list(child_list, 0), do: child_list

def get_child_list(child_list, num_of_nodes) do
  child = 
    %{  
    id: :rand.uniform(num_of_nodes*100000),
    start: {Gossip_node, :start_link, [[0,true]]}
  }  
  if num_of_nodes > 0 do
   
    get_child_list( [child] ++ child_list, num_of_nodes-1)
  end
end

def init(args) do
  children = get_child_list([], 10)
  # The outut of this inspect is pasted below
  IO.inspect children, label: "The children list is"
  // some function that does something parse_args_and_start(args)
  // num_of_nodes is 10
  children = get_child_list([], num_of_nodes)
  Supervisor.init(children, strategy: :simple_one_for_one)

end

I get the following error
bad child specification, invalid children: [%{id: 83303, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 186070, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 85483, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 40851, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 85216, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 390428, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 466922, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 187412, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 103750, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 176391, start: {Gossip_node, :start_link, [[0, true]]}}]

The Supervisor doc says that a supervisor is fine if it has a start and an id. Since children is a list I am adding multiple maps of children in it. Am i missing something. Gossip_node is a module in the same folder.

Marked As Solved

rvirding

rvirding

Creator of Erlang

In one sense these are not really dynamic children. Yes, we are starting input specified number of children but from the supervisors POV it is starting the children all at start-up time so they are not dynamic. They could just as well be specified as a list of children to start.

Also there are no problems with dynamically starting children in a “normal” Supervisor. There is a Supervisor.start_child/2 which does this. This is the same as for DynamicSupervisor which also has a DynamicSupervisor.start_child/2. Both these functions need a child-spec. The main difference is how the children are terminated: in a Supervisor they are terminated in reverse order to which they were started; while in a DynamicSupervisor they are all terminated at the same time.

:simple_one_for_one is/was slightly different in that when you started the supervisor you gave one child spec which is then used as a template for all the children started/managed by it. It is/was a special case for running lots of the same thing.

Both Supervisor and DynamicSupervisor have a terminate_chlid/2 for killing children.

Also Liked

prateek1192

prateek1192

Thanks for looking into it @kokolegorille
I started looking into that but then they say that

The Supervisor module was designed to handle mostly static children that are started in the given order when the supervisor starts. A DynamicSupervisor starts with no children. Instead, children are started on demand via start_child/2

I don’t need to start children on demand. When my supervisor starts up it knows what processes it needs to supervise. Anyways with that Dynamic Supervisor too I might have run into the same error when trying to supervise multiple children as I would have tried to add them into the list.

rvirding

rvirding

Creator of Erlang

In this case :one_for_one would be the best choice, although that will probably not fix this error.

Where Next?

Popular in Questions Top

jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod – where is this set? Thanks.
New
hariharasudhan94
I would like to know what is the best IDE for elixir development?
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
komlanvi
Hi everyone, I was playing with phoenix liveView but I run into an issue. I have a form and want to validate each input text when the te...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New
romenigld
I am trying to run a deploy with docker and I successfully runned with this command: docker build -t romenigld/blog-prod . but when I t...
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New

Other popular topics Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New
sorentwo
Hello! tl;dr Announcing Oban, an Ecto based job processing library with a focus on reliability and historical observability. After spen...
985 44778 311
New
dblack
I’ve got an issue with an app and I’ve no idea of how to troubleshoot it. I’m hoping someone here might have seen something similar. I p...
New
TunkShif
This post is an instruction guide to help you setup your Neovim for Elixir development from scratch. It includes general information on h...
274 42716 114
New

We're in Beta

About us Mission Statement