svilen

svilen

Author of Concurrent Data Processing in Elixir

Creating list adding elements on specific conditions?

Often I want to create a list in Elixir that contains certain elements, but only if specific conditions are met for each element or group of elements.

In a language with mutable data, it would be something like

array = [0]

if (cond1) {
  array.push(1)
}
if (cond2) {
  array.push(2)
}
if (cond3) {
  array.push(3)
}

return array

How would you re-write this in Elixir?

Currently I’ve been creating separate lists for each condition and concatenating them in the end:

initial = [0]
list_1 = if cond1 do
  [1]
else
  []
end

list_2 = if cond2 do
  [2]
else
  []
end

list_3 = if cond3 do
  [3]
else
  []
end

Enum.concat(initial, list_1)
|> Enum.concat(list_2)
|> Enum.concat(list_3)

This works but it’s not great, because I have to make sure I return an empty list every time. In some cases where logic in the if-block is complicated, it could lead to a lot of else [] end.

Any ideas how to refactor this to something more concise and/or avoid repetition are appreciated. Thanks!

First Post!

benwilson512

benwilson512

Author of Craft GraphQL APIs in Elixir with Absinthe

There are some options, but some of them depend on what exactly cond1 is. By just having it as cond1 we’re just left with booleans, so the pattern matching isn’t as clean as it could be. Can you give some examples of conditions? A simple solution for your booleans is:

conditions =[
  {cond1, 1},
  {cond2, 2},
  {cond3, 3},
]

list = Enum.reduce(conditions, [0], fn
  {true, item}, list -> [item | list]
  _, list -> list
end)

The idea is that we setup the conditions and the value associated with those conditions. Then we reduce those conditions into the list. If the condition is true, then we add the item. if it’s false, we don’t. If you need it to be appended instead of prepended you can just |> Enum.reverse afterward.

Most Liked

josevalim

josevalim

Creator of Elixir

My preferred approach would be:

[]
|> prepend_if_true(cond1, [1])
|> prepend_if_true(cond2, [2])
|> prepend_if_true(cond3, [3])
|> Enum.reverse()

defp prepend_if_true(list, cond, extra) do
  if cond, do: extra ++ list, else: list
end
10
Post #4
gregvaughn

gregvaughn

Just a couple of weeks ago we had something similar come up which involved collecting key/values into a map based upon conditions in another data structure. I came up with this helper function:

  defp conditional_put(map, _key, nil), do: map
  defp conditional_put(map, key, val), do: Map.put(map, key, val)

and for decimals:

  defp conditional_put_decimal(map, _key, nil), do: map
  defp conditional_put_decimal(map, key, num_str) do
    case Decimal.parse(num_str) do
      {:ok, num} -> Map.put(map, key, num)
      :error   -> map
    end
  end

Those pipeline nicely.

svilen

svilen

Author of Concurrent Data Processing in Elixir

Thank you @josevalim and @gregvaughn!

I took a bit of everyone’s suggestions and ended up with this helper function which I think strikes the best balance for me; I’m not manipulating large lists on this occasion, so I opted for appending rather than prepending for convenience:

  def cond_append(list, false, _), do: list
  def cond_append(list, true, fun) do
    list ++ [fun.()]
  end
  def cond_append(list, bool_fun, value_fun) do
    if bool_fun.(), do: list ++ [value_fun.()], else: list
  end

I do have complex bool logic sometimes, hence the extra version accepting list, fun, fun.

Thanks everyone :beers:

Last Post!

NobbZ

NobbZ

You can assume that ++/2 is implemented like this:

def ++([h|t], l2), do: [h|t++l2]
def ++([], l2), do: l2

This is what happens under the hood, even though it is implemented as a BIF IIRC.

Where Next?

Popular in Questions Top

Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
ovidiubadita
Hey all, I discovered Elixir and I love it. I always wanted to learn a functional programming and I intended to go for Haskell, but afte...
New
dokuzbir
I want to highlight html closing tags when i click a html tag. That works in .html files but doesnt work for html.eex templates. How can...
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
fireproofsocks
Forgive me if this is obvious, but how does one delete a database record WITHOUT selecting it first? Ecto.Repo — Ecto v3.14.0 has exampl...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New

Other popular topics Top

vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod – where is this set? Thanks.
New
stefanchrobot
What’s the safe way to decode a JSON string into a struct? I want to avoid calling String.to_atom. Jason.decode can give me a map with st...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 49134 226
New
saif
Hello everyone, Long time lurker first time poster here. I’ve recently begun working on Elixir full-time again! :raised_hands: It’s been...
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New

We're in Beta

About us Mission Statement