Sebb
The checks PipeChainStart and ABC-Size allow a parameter excluded_functions.
This does not seem to work.
I have this function credo does not like:
def hello do
Kernel.+(1, 1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
|> Kernel.+(1)
end
credo complains:
┃ [F] → Function is too complex (ABC size is 31, max is 30).
┃ lib/credo_check.ex:3:7 #(CredoCheck.hello)
┃ [F] → Pipe chain should start with a raw value.
┃ lib/credo_check.ex:5 #(CredoCheck.hello)
with this config:
{Credo.Check.Refactor.PipeChainStart, [excluded_functions: ["hello"]]},
{Credo.Check.Refactor.ABCSize, [excluded_functions: ["hello"]]},
I also tried
:hello"CredoCheck.hello""hello/0"~r/hello/
Trending in Questions
Hey guys,
I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly
Do you guys have any suggestions what is the best prac...
New
Hello!
Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app.
I creat...
New
I have what I’ve heard referred to as a “lookup table” in my database. This is a way of assigning codes to common values. One common lo...
New
Hello,
I’m developing a online persistent chat system (what’s app) like using elixir/dynamodb/aws for a mobile app(flutter).
The diffic...
New
What approach to take when sending live updates to “random” users Hi! I have a question, I have a little chat app, and when I create a DM...
New
Anyone here using Honeybadger?
My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of
Bandit.HTTPError...
New
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
Other Trending Topics
Hobbes is a low-level distributed database for the Elixir programming language.
Hobbes provides a simple, safe, and scalable storage lay...
New
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve.
They are GUI (Emerge) and State management (S...
New
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
There are three potential reasons for members of this forum to have a look at https://vutuv.de
You are tired or annoyed of LinkedIn.
Yo...
New
Aludel - LLM Evaluation Workbench
Aludel is an embeddable Phoenix LiveView dashboard for evaluating and comparing LLM prompts across mult...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #blog-post
- #elixir-ls
- #ai
- #elixirconf-us
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #hex
- #security
- #metaprogramming










Showing Posts 1 to 6- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
al2o3cr
Based on the tests for
PipeChainStart,excluded_functionsis a list of functions that are allowed to start a chain, not functions that are allowed to have a chain in them:https://github.com/rrrene/credo/blob/61a91b0abf3b085f60a41703d2fbcf361b5c1481/test/credo/check/refactor/pipe_chain_start_test.exs#L219-L229
You likely want inline config comments on
helloinstead.Sebb
thanks for looking into this.
Makes sense for Pipe, but for ABC
excluded_functionsshould exclude functions that are allowed to be complex, right?al2o3cr
Looks like Pipe has similar functionality, for similar reasons:
https://github.com/rrrene/credo/blob/61a91b0abf3b085f60a41703d2fbcf361b5c1481/test/credo/check/refactor/abc_size_test.exs#L255-L271
ViseLuca
Hi but how can I exclude a function?
For example I have
How can I exclude the
fromfunction to be warned by credo?gregvaughn
This may be an unwelcome tangent, but credo would not complain if you wrote this code in the more idiomatic way
DavidRawk-Blake
The example is contrived. I don’t understand how people can’t see this. It’s meant to be silly..
Sometimes a function is only complex if you can’t read. Which is perfectly sane for a linter to catch. But the OP code isn’t complex.