zkessin

zkessin

I want to add Credo to an existing project, and of course, when it runs it flags a lot of problems. What I want to know is there a built-in way to cause Credo to ignore the known issues, but report an error on new issues that may come up? That way the existing issues can be handled over time while we prevent any more issues from happening

Showing Posts 1 to 4

srowley

srowley

I am not aware of anything Credo does to remember results of prior runs, but it does allow you to ignore specific lines or files, if you are willing able to go through the code and apply those exceptions.

hauleth

hauleth

You can use ReviewDog to filter out failures limiting them to only the errors in current diff.

zoldar

zoldar

As a kind of a workaround, you could use git to select only files that changed relative to the base branch for credo checks. It’s still coarse grained but allows for incrementally improving credo compliance of the code base (however that assumes branch-based workflow so YMMV).

NOTE: I didn’t run this code (it’s a heavily edited and simplified version of an existing solution). It should give an idea though.

defmodule Mix.Tasks.Credo.Ci do
  use Mix.Task

  @impl true
  def run(_) do
    if System.cmd("git", ["rev-parse", "--abbrev-ref", "HEAD"]) == {"master", 0} do
      Mix.Task.run("credo", [])
    else
      {head_sha, 0} = System.cmd("git", ["rev-parse", "HEAD"])

      {closest_ancestor_sha, 0} =
        System.cmd("git", [
          "merge-base",
          String.trim(head_sha),
          "origin/master",
        ])

      {diff, 0} = System.cmd("git", ["diff", "--name-only", String.trim(closest_ancestor_sha)])

      files =
        diff
        |> String.split("\n")
        |> Enum.filter(&(&1 =~ ~r/(lib|test).*\.exs?/))
        |> Enum.flat_map(&["--files-included", &1])

      unless files == [] do
        Mix.Task.run("credo", ["-C", config_name | files])
      end
    end
  end
end
m1dnight

m1dnight

I noticed @hauleth s comment and I decided to figure out how to do it locally.

My workflow would be to run credo on my current changes not staged for committing. To only get reports on the current unstaged changes is done as follows.

mix credo --strict --format=flycheck | reviewdog -efm="%f:%l:%c: %t: %m" -efm="%f:%l: %t: %m" -name="credo" -diff="git diff"

The key here is to play around with the -diff command. That’s the output reviewdog will use to determine which violations (according to credo) are relevant to show you.

Say you want to get only new issues since you created your feature branch off of the develop branch, this will do too:

mix credo --strict --format=flycheck | reviewdog -efm="%f:%l:%c: %t: %m" -efm="%f:%l: %t: %m" -name="credo" -diff="git diff HEAD $(git merge-base HEAD develop) "

— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews