zkessin

zkessin

I want to add Credo to an existing project, and of course, when it runs it flags a lot of problems. What I want to know is there a built-in way to cause Credo to ignore the known issues, but report an error on new issues that may come up? That way the existing issues can be handled over time while we prevent any more issues from happening

Showing Posts 1 to 4

srowley

srowley

I am not aware of anything Credo does to remember results of prior runs, but it does allow you to ignore specific lines or files, if you are willing able to go through the code and apply those exceptions.

hauleth

hauleth

You can use ReviewDog to filter out failures limiting them to only the errors in current diff.

zoldar

zoldar

As a kind of a workaround, you could use git to select only files that changed relative to the base branch for credo checks. It’s still coarse grained but allows for incrementally improving credo compliance of the code base (however that assumes branch-based workflow so YMMV).

NOTE: I didn’t run this code (it’s a heavily edited and simplified version of an existing solution). It should give an idea though.

defmodule Mix.Tasks.Credo.Ci do
  use Mix.Task

  @impl true
  def run(_) do
    if System.cmd("git", ["rev-parse", "--abbrev-ref", "HEAD"]) == {"master", 0} do
      Mix.Task.run("credo", [])
    else
      {head_sha, 0} = System.cmd("git", ["rev-parse", "HEAD"])

      {closest_ancestor_sha, 0} =
        System.cmd("git", [
          "merge-base",
          String.trim(head_sha),
          "origin/master",
        ])

      {diff, 0} = System.cmd("git", ["diff", "--name-only", String.trim(closest_ancestor_sha)])

      files =
        diff
        |> String.split("\n")
        |> Enum.filter(&(&1 =~ ~r/(lib|test).*\.exs?/))
        |> Enum.flat_map(&["--files-included", &1])

      unless files == [] do
        Mix.Task.run("credo", ["-C", config_name | files])
      end
    end
  end
end
m1dnight

m1dnight

I noticed @hauleth s comment and I decided to figure out how to do it locally.

My workflow would be to run credo on my current changes not staged for committing. To only get reports on the current unstaged changes is done as follows.

mix credo --strict --format=flycheck | reviewdog -efm="%f:%l:%c: %t: %m" -efm="%f:%l: %t: %m" -name="credo" -diff="git diff"

The key here is to play around with the -diff command. That’s the output reviewdog will use to determine which violations (according to credo) are relevant to show you.

Say you want to get only new issues since you created your feature branch off of the develop branch, this will do too:

mix credo --strict --format=flycheck | reviewdog -efm="%f:%l:%c: %t: %m" -efm="%f:%l: %t: %m" -name="credo" -diff="git diff HEAD $(git merge-base HEAD develop) "

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
rlipscombe
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
rlipscombe
When I use Mix.install with a git dependency, using git@github.com:... how do I change the SSH identity used? I’ve got two Github accoun...
New
adr
Hello all. I have a question as to best practices for code organization when implementing a liveview with a lot of responsibilities. Sup...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
raa-ziq
Hi everyone :waving_hand: I wanted to share something I’ve been building — NowBlind, a random chat app designed to help people discover ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New
kip
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New

Latest on Elixir Forum

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews