kwando

kwando

Custom Ecto.Type for :id is not "loaded"

I have a custom ecto type defined like below.

defmodule MyApp.Account do
  use Ecto.Schema
  @primary_key {:id, MyApp.AccountID, autogenerate: true}
  schema "accounts" do
    field :name, :string
    # ... more fields here
  end
end

defmodule MyApp.AccountID do
  @behaviour Ecto.Type
  @hashids Hashids.new(min_len: 8, salt: "**salt**")
  @moduledoc """
  Converts integers to Hashids.

  See http://hashids.org/ for more information.
  """
  
  def type(), do: :id

  def cast(term) when is_integer(term), do: {:ok, Hashids.encode(@hashids, term)}
  def cast(term) when is_binary(term),  do: dump(term)
  def cast(_), do: :error

  def dump(term) when is_binary(term) do
    Hashids.decode!(@hashids, term)
    |> case do
      [int] -> {:ok, int}
      _ -> :error
    end
  end
  def dump(term) when is_integer(term), do: {:ok, term}
  def dump(_), do: :error

  def load(term) when is_integer(term), do: cast(term)
  def load(_), do: :error
end

When inserting into a Repo I get integer (:id) keys back from Ecto.

%MyApp.Account{name: "hello"}
|> MyApp.Repo.insert

This returns {:ok, %MyApp.Account{id: 323, name: "hello"} but I’m expecting that the id field should be passed through the load function on my custom type on it’s way back from the database.

Is this a bug in Ecto or am I doing something wrong?

First 10 of 10 Posts! Switch mode

kwando

kwando

I’m using the name :id because I want my database to generate the primary key for me, I have not figured out another way to “trick” the database (postgres) do it for me. :confused:

idi527

idi527

Your code seems to work for me

iex(2)> Repo.get(User, 1)

16:32:45.641 [debug] QUERY OK source="users" db=2.5ms decode=4.2ms
SELECT u0."id", u0."name" FROM "users" AS u0 WHERE (u0."id" = $1) [1]
%User{
  __meta__: #Ecto.Schema.Metadata<:loaded, "users">,
  id: "ro5OZvxp",
  name: "asdf"
}

It returns user id as integer from insert since it returns what it sends, and it sends an integer.

kwando

kwando

Yep, it works fine when using Repo.get/2. But see what Repo.insert(%Users{name: "hello"}) returns :slight_smile:

kwando

kwando

Yes, but in this case I’m actually getting the auto incremented integer from the database..

idi527

idi527

You are right, I’m not thinking straight …

kwando

kwando

Hmm, if I swap autogenerate: true for read_after_writes: true on the field options it seems to work as expected :slight_smile:

Can someone verify if this is the correct thing to do?

defmodule MyApp.Account do
  use Ecto.Schema
  @primary_key {:id, MyApp.AccountID, read_after_writes: true}
  schema "accounts" do
    field :name, :string
    # ... more fields here
  end
end
michalmuskala

michalmuskala

This might be a bug in ecto that we don’t correctly load ids. Could you open an issue, ideally with a simple way to reproduce the issue?

kwando

kwando

I’ll build you something to play with tomorrow :slight_smile:

obsidienne

obsidienne

I can’t find any issue on github. Can you post here the issue number ?
thanks

Where Next?

Trending in Questions Top

jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
saveman71
Hello ! We want new/edit form pages to POST/PUT to their own URL rather than the resources REST defaults (post /things, put /things/:id)...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement