freewebwithme

freewebwithme

I need some help to understand writing test for async function

For example I have a function

def send_notification({:ok, nessage}, to, title, body) do
    Task.Supervisor.async_nolink(MyApp.TaskSupervisor, fn -> 
        send(to, title, body)
    end)
end

def create(to, title, body) do
  to
  |> create_message(title, body)
  |> send(to, title, body)
  |> log_message()
end

If I run test for create function, I got an error

13:19:41.877 [error] Postgrex.Protocol (#PID<0.1313.0>) disconnected: ** (DBConnection.ConnectionError) owner #PID<0.4033.0> exited

Client #PID<0.4035.0> is still using a connection from owner at location:

    :prim_inet.recv0/3
    (postgrex 0.16.5) lib/postgrex/protocol.ex:3171: Postgrex.Protocol.msg_recv/4
    (postgrex 0.16.5) lib/postgrex/protocol.ex:2871: Postgrex.Protocol.recv_transaction/4
    (postgrex 0.16.5) lib/postgrex/protocol.ex:2180: Postgrex.Protocol.rebind_execute/4
    (ecto_sql 3.9.1) lib/ecto/adapters/sql/sandbox.ex:375: Ecto.Adapters.SQL.Sandbox.Connection.proxy/3
    (db_connection 2.4.3) lib/db_connection/holder.ex:354: DBConnection.Holder.holder_apply/4
    (db_connection 2.4.3) lib/db_connection.ex:1413: DBConnection.run_execute/5
    (db_connection 2.4.3) lib/db_connection.ex:1508: DBConnection.run/6
    (db_connection 2.4.3) lib/db_connection.ex:701: DBConnection.execute/4
    (ecto_sql 3.9.1) lib/ecto/adapters/postgres/connection.ex:102: Ecto.Adapters.Postgres.Connection.execute/4
    (ecto_sql 3.9.1) lib/ecto/adapters/sql.ex:858: Ecto.Adapters.SQL.execute!/5
    (ecto_sql 3.9.1) lib/ecto/adapters/sql.ex:828: Ecto.Adapters.SQL.execute/6
    (ecto 3.9.4) lib/ecto/repo/queryable.ex:229: Ecto.Repo.Queryable.execute/4
    (ecto 3.9.4) lib/ecto/repo/queryable.ex:19: Ecto.Repo.Queryable.all/3
    (ecto 3.9.4) lib/ecto/repo/preloader.ex:272: Ecto.Repo.Preloader.fetch_query/8
    (elixir 1.14.2) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
    (ecto 3.9.4) lib/ecto/repo/preloader.ex:72: Ecto.Repo.Preloader.preload_each/4
    (ecto 3.9.4) lib/ecto/repo/preloader.ex:51: Ecto.Repo.Preloader.normalize_and_preload_each/5
    (ecto 3.9.4) lib/ecto/repo/preloader.ex:46: Ecto.Repo.Preloader.preload/4

And I read the doc But I can’t figure out how to write test for this async function

And sandbox is :manual mode

Ecto.Adapters.SQL.Sandbox.mode(MyAppRepo, :manual)

Showing Posts 1 to 6

al2o3cr

al2o3cr

In manual mode, the sandbox works with Task behind the scenes to ensure that the task process gets allowed to share the connection with the caller.

HOWEVER

That means that the task cannot outlive the test process, or you’ll get the error you’re seeing.

A quick way to check if this might be causing your issue would be to add Process.sleep(5000) or similar to the end of the test that’s failing. That will ensure the call to send completes before the test does.

bolducp

bolducp

@al2o3cr Do you have advice about the best way to handle this in a test? I’ve got some code that uses Task.start to call some side effect functions that I don’t care about the results of. But my tests that uses the parent function are returning this error now, because the Task is trying to outlive the test.
Is the best way to insert Process.sleep/1 statements? Or is there a better way?

tim.jarratt

tim.jarratt

I’ve been fighting this exact same problem in some of the tests in a project at work. I’m not using the Task API, but I see the same problem when testing GenServers and with some async LiveViews.

Our current approach is to have our tests safely kill the spawned process, and to ensure it has stopped before the test ends. The reason for this is that the fundamental problem is that the spawned process is killed while it is still expecting to receive data from the Postgrex process – which rightly complains when the process on the other end disappears.

I’d love for this to be easier, but right now we need to spend a lot of time identifying which tests are failing, and then building custom ways to ensure our process is either stopped cleanly or isn’t in the middle of a query.

josevalim

josevalim

Creator of Elixir

Nowadays we have proper abstractions in place so this doesn’t happen as often.

First, for managing connections, make sure you are using the start_owner API: todo_trek/test/support/data_case.ex at main · chrismccord/todo_trek · GitHub

When you are starting processes under test, use start_supervisor! from ExUnit, which guarantees it will be shut down before the test process.

Finally, if you are starting tasks or processes under a supervisor dynamically, add an on_exit callback that gets all children of said supervisor and wait for them to terminate. Something like:

on_exit(fn ->
  for {_, pid, _, _} <- DynamicSupervisor.which_children(YourSupName) do
    ref = Process.monitor(pid)
    assert_receive {:DOWN, ^ref, _, _, _}, :infinity
  end
end)
Joep

Joep

When searching for start_supervisor! in the docs I get no results: Search — ExUnit v1.20.2!

Sorry, we couldn’t find anything for start_supervisor!.

I suppose you mean start_supervised!/2 ?

dimitarvp

dimitarvp

Yep, that’s the one.

— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews