kip

kip

ex_cldr Core Team

Decimal.to_integer strangeness

I’m hoping smarter eyes than mine can help me resolve this issue. I am attempting to convert a decimal to an integer. The Decimal implementation uses guard clauses to decide if such as conversion is possible (good!). But for some reason I’m seeing guard clauses fail even when the data looks like it should pass. Here’s the example:

# A decimal. Shouldn't be able to be converted to an integer
# but it looks like the guards for the third clause should match and I
# don't know why they aren't!
iex> d = Decimal.new("1234.50")
#Decimal<1234.50>

# Here's what the struct underneath looks like:
iex> inspect d, structs: false
"%{__struct__: Decimal, coef: 123450, exp: -2, sign: 1}"

# Lets check the remainder of the coef
iex> Kernel.rem(d.coef,10)
0

# Error raises on conversion suggesting no guards match but
# I think the third clause should match?
iex> Decimal.to_integer d                     
** (FunctionClauseError) no function clause matching in Decimal.to_integer/1    
    
    The following arguments were given to Decimal.to_integer/1:
    
        # 1
        #Decimal<1234.5>
    
    Attempted function clauses (showing 3 out of 3):
    
        def to_integer(%Decimal{sign: sign, coef: coef, exp: 0}) when is_integer(coef)
        def to_integer(%Decimal{sign: sign, coef: coef, exp: exp}) when is_integer(coef) and exp > 0
        def to_integer(%Decimal{sign: sign, coef: coef, exp: exp}) when is_integer(coef) and exp < 0 and rem(coef, 10) == 0
    
    (decimal 2.0.0) lib/decimal.ex:1322: Decimal.to_integer/1

But in my example is_integer(coef) == true and exp < 0 == true and rem(coef, 10) == 0 so why isn’t this clause being executed?

Probably an issue with me staring at a screen for too long so any guidance appreciated.

Marked As Solved

Aetherus

Aetherus

I did my experiment by copy and paste:

defmodule MyDecimal do
  # `to_integer/1` is copied from the source code of `Decimal`,
  # and added some `IO.inspect`

  def to_integer(%Decimal{sign: sign, coef: coef, exp: 0} = d)
      when is_integer(coef) do
        IO.inspect(d, label: "Branch 1", structs: false)
        sign * coef
      end

  def to_integer(%Decimal{sign: sign, coef: coef, exp: exp} = d)
      when is_integer(coef) and exp > 0 do
        IO.inspect(d, label: "Branch 2", structs: false)
        to_integer(%Decimal{sign: sign, coef: coef * 10, exp: exp - 1})
      end

  def to_integer(%Decimal{sign: sign, coef: coef, exp: exp} = d)
      when is_integer(coef) and exp < 0 and Kernel.rem(coef, 10) == 0 do
        IO.inspect(d, label: "Branch 3", structs: false)
        to_integer(%Decimal{sign: sign, coef: Kernel.div(coef, 10), exp: exp + 1})
      end
end

MyDecimal.to_integer(Decimal.new("1234.50"))

and it prints

Branch 3: %{__struct__: Decimal, coef: 123450, exp: -2, sign: 1}

** (FunctionClauseError) no function clause matching in MyDecimal.to_integer/1

The following arguments were given to MyDecimal.to_integer/1:

    # 1
    #Decimal<1234.5>

    #cell:2: MyDecimal.to_integer/1

So, the “problem” occurs when trying to do to_integer(%Decimal{sign: 1, coef: 12345, exp: -1}).

Maybe Decimal does not want you to do anything ambiguous about the fraction part.

Also Liked

kip

kip

ex_cldr Core Team

Thanks very much for following this through. And spotting my silly error - which is to not notice that the third clause is recursive (as it needs to be). I know that the number can’t be converted to an integer, I just couldn’t see why it wouldn’t match on the third clause. And indeed it does match on the first pass. I missed that it was recursing and not matching on a later pass (in fact there is an accepted PR that handles this error case better then the published version).

Thanks again.

wojtekmach

wojtekmach

Hex Core Team

I think latest Decimal should have a proper error message. Or maybe that change wasn’t released yet. If still have a bad error message, that’s definitely a bug and please report it!

Where Next?

Popular in Questions Top

Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
9mm
I am constructing a JSON object (map) and I need to conditionally set a field. I’m trying to write proper elixir-way code… and I’m at a l...
New
chrisalley
ExUnit now has describe blocks which is a welcome addition coming from RSpec. In the docs, it states that nested hierarchies of describe ...
New
hariharasudhan94
lets say i have a sample like a = 20; b = 10; if (a &gt; b) do {:ok, "a"} end if (a &lt; b) do {:ok, b} end if (a == b) do {:ok, "equa...
New
dokuzbir
I want to highlight html closing tags when i click a html tag. That works in .html files but doesnt work for html.eex templates. How can...
New
beno
I will often find my self writing things similar to: case some_value do nil -&gt; something() "" -&gt; something() _ -&gt; somethi...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
RisingFromAshes
I’ve read in another post that it may be possible with a router helper - but I couldn’t find an appropriate one, and tbh, I’m still just ...
New
JDanielMartinez
Hi! May someone helps me, please! I have two apps into an umbrella project: the first one is Database, which manages queries, and the se...
New

Other popular topics Top

Nvim
Anybody knows a comprehensive comparison of Django and Phoenix, thanks for the help. Where are they similar? Where do they differ the m...
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
AngeloChecked
What learn first? Rust or Elixir Hi Elixir community! I’m here because i want learn a new language. I’m a junior developer and mainly i ...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New
pmjoe
I have a relationship of love and hate with Elixir. Lots of things are just absolutely right, but there are some things that are kind of ...
New
Emily
I have VueJS GUIs with the project generated using Webpack. I have Elixir modules that will need to be used by the VueJS GUIs. I forese...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
AstonJ
We’ve put together this wiki for Phoenix LiveView - please feel free to add any info you feel is worth including. What is Phoenix LiveV...
New
PeterCarter
There are pre-rolled solutions for other frameworks that do work. However, Phoenix does not seem to have these. Have people had good expe...
New
sergio
Kind of like when jquery came out, it was super necessary. Existing drag and drop libraries have a bunch of baggage to support old browse...
New

We're in Beta

About us Mission Statement