kip

kip

ex_cldr Core Team

Decimal.to_integer strangeness

I’m hoping smarter eyes than mine can help me resolve this issue. I am attempting to convert a decimal to an integer. The Decimal implementation uses guard clauses to decide if such as conversion is possible (good!). But for some reason I’m seeing guard clauses fail even when the data looks like it should pass. Here’s the example:

# A decimal. Shouldn't be able to be converted to an integer
# but it looks like the guards for the third clause should match and I
# don't know why they aren't!
iex> d = Decimal.new("1234.50")
#Decimal<1234.50>

# Here's what the struct underneath looks like:
iex> inspect d, structs: false
"%{__struct__: Decimal, coef: 123450, exp: -2, sign: 1}"

# Lets check the remainder of the coef
iex> Kernel.rem(d.coef,10)
0

# Error raises on conversion suggesting no guards match but
# I think the third clause should match?
iex> Decimal.to_integer d                     
** (FunctionClauseError) no function clause matching in Decimal.to_integer/1    
    
    The following arguments were given to Decimal.to_integer/1:
    
        # 1
        #Decimal<1234.5>
    
    Attempted function clauses (showing 3 out of 3):
    
        def to_integer(%Decimal{sign: sign, coef: coef, exp: 0}) when is_integer(coef)
        def to_integer(%Decimal{sign: sign, coef: coef, exp: exp}) when is_integer(coef) and exp > 0
        def to_integer(%Decimal{sign: sign, coef: coef, exp: exp}) when is_integer(coef) and exp < 0 and rem(coef, 10) == 0
    
    (decimal 2.0.0) lib/decimal.ex:1322: Decimal.to_integer/1

But in my example is_integer(coef) == true and exp < 0 == true and rem(coef, 10) == 0 so why isn’t this clause being executed?

Probably an issue with me staring at a screen for too long so any guidance appreciated.

Marked As Solved

Aetherus

Aetherus

I did my experiment by copy and paste:

defmodule MyDecimal do
  # `to_integer/1` is copied from the source code of `Decimal`,
  # and added some `IO.inspect`

  def to_integer(%Decimal{sign: sign, coef: coef, exp: 0} = d)
      when is_integer(coef) do
        IO.inspect(d, label: "Branch 1", structs: false)
        sign * coef
      end

  def to_integer(%Decimal{sign: sign, coef: coef, exp: exp} = d)
      when is_integer(coef) and exp > 0 do
        IO.inspect(d, label: "Branch 2", structs: false)
        to_integer(%Decimal{sign: sign, coef: coef * 10, exp: exp - 1})
      end

  def to_integer(%Decimal{sign: sign, coef: coef, exp: exp} = d)
      when is_integer(coef) and exp < 0 and Kernel.rem(coef, 10) == 0 do
        IO.inspect(d, label: "Branch 3", structs: false)
        to_integer(%Decimal{sign: sign, coef: Kernel.div(coef, 10), exp: exp + 1})
      end
end

MyDecimal.to_integer(Decimal.new("1234.50"))

and it prints

Branch 3: %{__struct__: Decimal, coef: 123450, exp: -2, sign: 1}

** (FunctionClauseError) no function clause matching in MyDecimal.to_integer/1

The following arguments were given to MyDecimal.to_integer/1:

    # 1
    #Decimal<1234.5>

    #cell:2: MyDecimal.to_integer/1

So, the “problem” occurs when trying to do to_integer(%Decimal{sign: 1, coef: 12345, exp: -1}).

Maybe Decimal does not want you to do anything ambiguous about the fraction part.

Also Liked

kip

kip

ex_cldr Core Team

Thanks very much for following this through. And spotting my silly error - which is to not notice that the third clause is recursive (as it needs to be). I know that the number can’t be converted to an integer, I just couldn’t see why it wouldn’t match on the third clause. And indeed it does match on the first pass. I missed that it was recursing and not matching on a later pass (in fact there is an accepted PR that handles this error case better then the published version).

Thanks again.

wojtekmach

wojtekmach

Hex Core Team

I think latest Decimal should have a proper error message. Or maybe that change wasn’t released yet. If still have a bad error message, that’s definitely a bug and please report it!

Where Next?

Popular in Questions Top

New
senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
skosch
To my knowledge, put_in, Map.update etc. all have the one limitation of not automatically creating intermediate keys when needed (for exa...
New
greenz1
I have a phoenix application from which a user can download multiple(5-6) files of size 1MB. I couldn’t find anything related to sending ...
New
shahryarjb
Hello, I have map which I want to convert it to string like this: the map: %{last_name: "tavakkoli", name: "shahryar"} the string I ne...
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
jerry
Good day to you all. I have been struggling to get a query involving like and ilike to work. Can anyone assist me on this, please? pro...
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
Brian
What is the proper way to load a module from a file in to IEX? In the python world, doing something like this pretty standard: from ....
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New

Other popular topics Top

senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
TunkShif
This post is an instruction guide to help you setup your Neovim for Elixir development from scratch. It includes general information on h...
274 41539 114
New
ovidiubadita
Hey all, I discovered Elixir and I love it. I always wanted to learn a functional programming and I intended to go for Haskell, but afte...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New
pmjoe
I have a relationship of love and hate with Elixir. Lots of things are just absolutely right, but there are some things that are kind of ...
New
grych
Hi folks, Few months ago I have announced the proof-of-concept of the library to manipulate the browsers DOM objects directly from Elixi...
639 52341 488
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New
dogweather
I wrote this comment on r/haskell, and it’s not popular there. :wink: But I think I’m on to something… Haskell reminds me of Java, and e...
New
svb
Hi! Currently I want to submit a form by pressing the Enter key. However, since my input field is of type “textarea” this is just adds a...
New

We're in Beta

About us Mission Statement