Deveh

Deveh

Dialyzer (dialyxir) unmatched_return warning

So, I’m writing my home project with Elixir, everything’s going fine, decided to plug dialyxir to scan for some potential issues and it gives me this one error:

lib/http_server.ex:60:unmatched_return
The expression produces a value of type:

:ok | pid()

but this value is unmatched.

Code in question:

  defp accept_loop(listen_socket, %State{} = state) do
    state = %{state | total_calls: state.total_calls + 1}

    case :gen_tcp.accept(listen_socket) do # LINE 60, issue is here
      {:ok, client_socket} ->
        spawn(fn -> serve(client_socket, state) end)

      {:error, data} ->
        Logger.notice("Error accepting client socket - #{inspect(data)}")
    end

    accept_loop(listen_socket, state)
  end

Error about unmatched value from gen_tcp.accept. Everything’s working fine and according to documentation I’m matching values just fine - gen_tcp — OTP 29.0.2 (kernel 11.0.2) :

accept(ListenSocket) -> {ok, Socket} | {error, Reason}

I am matching both {:ok, socket} and {:error, reason} so I am at a loss now. What is going on?

Tried adding guard to :ok match - {:ok, client_socket} when is_port(client_socket) -> but mix dialyzer still returns same error.

Tried capturing first variable and checking whether it’s :ok or a pid - {test, client_socket} when test == :ok or is_pid(test) - still same error.

Marked As Solved

Deveh

Deveh

Ah, I see.

It’s the case statement itself that returns either pid from first match - spawn is called - or :ok from second match - Logger.notice call - and THAT is unmatched. So, with this insight, this is an easy “”“fix”“”, as I don’t give a damn about what case returns.

  defp accept_loop(listen_socket, %State{} = state) do
    state = %{state | total_calls: state.total_calls + 1}

    _ = case :gen_tcp.accept(listen_socket) do
      {:ok, client_socket} ->
        spawn(fn -> serve(client_socket, state) end)

      {:error, data} ->
        Logger.notice("Error accepting client socket - #{inspect(data)}")
    end

    accept_loop(listen_socket, state)
  end

Also Liked

BartOtten

BartOtten

Sorry, can’t give you a solution. But maybe this might help. If not, you still learned some valuable lessons.

I once stumbled upon a blog post
https://medium.com/erlang-battleground/help-dialyzer-help-you-94db66bfbc5a.

The blog post mentions the next video which helps me ‘think like dialyzer’ and so find solutions.

But before anything, remove your dialyzer cache. Lesson learned the hard way. See:

Where Next?

Popular in Questions Top

vonH
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New
Emily
I have VueJS GUIs with the project generated using Webpack. I have Elixir modules that will need to be used by the VueJS GUIs. I forese...
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
svb
Hi! Currently I want to submit a form by pressing the Enter key. However, since my input field is of type “textarea” this is just adds a...
New

Other popular topics Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
dogweather
I wrote this comment on r/haskell, and it’s not popular there. :wink: But I think I’m on to something… Haskell reminds me of Java, and e...
New
dblack
I’ve got an issue with an app and I’ve no idea of how to troubleshoot it. I’m hoping someone here might have seen something similar. I p...
New
romenigld
I am trying to run a deploy with docker and I successfully runned with this command: docker build -t romenigld/blog-prod . but when I t...
New

We're in Beta

About us Mission Statement