Deveh

Deveh

So, I’m writing my home project with Elixir, everything’s going fine, decided to plug dialyxir to scan for some potential issues and it gives me this one error:

lib/http_server.ex:60:unmatched_return
The expression produces a value of type:

:ok | pid()

but this value is unmatched.

Code in question:

  defp accept_loop(listen_socket, %State{} = state) do
    state = %{state | total_calls: state.total_calls + 1}

    case :gen_tcp.accept(listen_socket) do # LINE 60, issue is here
      {:ok, client_socket} ->
        spawn(fn -> serve(client_socket, state) end)

      {:error, data} ->
        Logger.notice("Error accepting client socket - #{inspect(data)}")
    end

    accept_loop(listen_socket, state)
  end

Error about unmatched value from gen_tcp.accept. Everything’s working fine and according to documentation I’m matching values just fine - gen_tcp — OTP 29.0.2 (kernel 11.0.2) :

accept(ListenSocket) -> {ok, Socket} | {error, Reason}

I am matching both {:ok, socket} and {:error, reason} so I am at a loss now. What is going on?

Tried adding guard to :ok match - {:ok, client_socket} when is_port(client_socket) -> but mix dialyzer still returns same error.

Tried capturing first variable and checking whether it’s :ok or a pid - {test, client_socket} when test == :ok or is_pid(test) - still same error.

Showing Posts 1 to 2

BartOtten

BartOtten

Sorry, can’t give you a solution. But maybe this might help. If not, you still learned some valuable lessons.

I once stumbled upon a blog post
https://medium.com/erlang-battleground/help-dialyzer-help-you-94db66bfbc5a.

The blog post mentions the next video which helps me ‘think like dialyzer’ and so find solutions.

But before anything, remove your dialyzer cache. Lesson learned the hard way. See:

Deveh

Deveh OP

Ah, I see.

It’s the case statement itself that returns either pid from first match - spawn is called - or :ok from second match - Logger.notice call - and THAT is unmatched. So, with this insight, this is an easy “”“fix”“”, as I don’t give a damn about what case returns.

  defp accept_loop(listen_socket, %State{} = state) do
    state = %{state | total_calls: state.total_calls + 1}

    _ = case :gen_tcp.accept(listen_socket) do
      {:ok, client_socket} ->
        spawn(fn -> serve(client_socket, state) end)

      {:error, data} ->
        Logger.notice("Error accepting client socket - #{inspect(data)}")
    end

    accept_loop(listen_socket, state)
  end
— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews