Sinc

Sinc

I ran dialyzer on this new code (with both Elixir 1.7 and 1.12) and am getting the error:

The pattern
variable_error

can never match, because previous clauses completely cover the type
:ok.

It points at the line in maybe_gen_certificates that does the put_error. I don’t understand why. The spec for generate_certificates should be correct, specifying :ok | {atom(), atom()}, and the with statement should be able to fail with {_, non_zero_integer} and return that as response. What am I missing?

  defp maybe_gen_certificates(config, false) do
    case generate_certificates() do
      :ok -> config
      error -> put_error(config, :certificate, error)
    end
  end

  @spec generate_certificates() :: :ok | {atom(), atom()}
  def generate_certificates do
    {key, cert} = keys()

    write_keys_permissions({key, cert})

    response =
      with {_, 0} <- System.cmd("openssl", ~w(genrsa -out #{key} 2048)),
           {_, 0} <- System.cmd("openssl", ~w(rsa -in #{key} -out #{cert} -outform PEM -pubout)),
           do: :ok

    reset_keys_permissions({key, cert})
    response
  end

Thanks! :smiley:

Showing Posts 1 to 2

LostKobrakai

LostKobrakai

System.cmd and therefore generate_certificates returns {Collectable.t(), exit_status :: non_neg_integer()} not {atom(), atom()} in the case of a non zero exit status.

Sinc

Sinc OP

That worked. Thanks.

I wonder why this doesn’t report that the spec doesn’t match the success typing of the function. That would have pointed me directly to the problem. I would think that if it was smart enough to know that the failure couldn’t actually return {atom, atom} that it would complain about what it should be returning. Or even recognize that there was a second option for return that the error would catch.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews