jmurphyweb

jmurphyweb

I have a Users module:

defmodule Delete.Users do
  def get_user, do: nil
end

I have. a module plug:

defmodule DeleteWeb.UserPlug do
  def init(_), do: []

  def call(conn, _opts) do
    Map.put(conn, :user, Delete.Users.get_user())
  end
end

I have a controller:

defmodule DeleteWeb.PageController do
  use DeleteWeb, :controller

  # The Module Plug version creates an implicit compile time dependency with `Users` module:
  # plug(DeleteWeb.UserPlug)

  # The locally defined function plug does not create an implicit compile time dependency 
  # with `Users` module:
  # defp user_plug(conn, _), do: Map.put(conn, :user, Delete.Users.get_user())
  # plug(:user_plug)

  def index(conn, _params) do
    render(conn, "index.html")
  end
end

I have init_mode set in my config:

config :phoenix, :plug_init_mode, :runtime

With the above setup, using the module UserPlug, updating Users recompiles PageController.

As my app grows, I will re-use this plug in all/most of controllers (as well as other similar plugs). Is it possible to share this plug around my various controllers without creating compile time dependencies all over the place?

Showing Posts 1 to 2

josevalim

josevalim

Creator of Elixir

It was a bug. It has been fixed on Phoenix master and v1.4 branches.

jmurphyweb

jmurphyweb OP

Thanks @josevalim

By v1.4 branches I take that to mean all phoenix versions: 1.4.x but obviously that is wrong as I have the following dependency: {:phoenix, "~> 1.4.14"}.

When updating to {:phoenix, git: "https://github.com/phoenixframework/phoenix.git"} I can see that both the function plug or the module plug do not create these implicit compile time dependencies.


In case anyone else is coming across this, the following does still of course cause implicit compile time dependency:

defmodule DeleteWeb.FunctionPlugs do
  def user_plug(_, _), do: Delete.Users.get_user()
end
defmodule DeleteWeb.PageController do
  use DeleteWeb, :controller

  # plug(DeleteWeb.Plugs.User)

  # defp user_plug(_, _), do: Delete.Users.get_user()
  # plug(:user_plug)

  import DeleteWeb.FunctionPlugs, only: [user_plug: 2]
  plug(:user_plug)

  def index(conn, _params) do
    render(conn, "index.html")
  end
end

So shared plugs are better to be Module Plugs rather than imported function plugs.

— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
kpanic
Hi everyone, I am toying with the idea of building a “match maker” for giving personal help to people that wants to start coding. I sta...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
asweet-confluent
I recently noticed that Elixir’s Logger defaults its primary log level to :debug when no :logger, :level application configuration is pre...
New
apz
I’m new to elixir and just tried to install the elixirLS extension for VScode(ium) and it is throwing some errors that I would like help ...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
New
JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews