jmurphyweb

jmurphyweb

I have a Users module:

defmodule Delete.Users do
  def get_user, do: nil
end

I have. a module plug:

defmodule DeleteWeb.UserPlug do
  def init(_), do: []

  def call(conn, _opts) do
    Map.put(conn, :user, Delete.Users.get_user())
  end
end

I have a controller:

defmodule DeleteWeb.PageController do
  use DeleteWeb, :controller

  # The Module Plug version creates an implicit compile time dependency with `Users` module:
  # plug(DeleteWeb.UserPlug)

  # The locally defined function plug does not create an implicit compile time dependency 
  # with `Users` module:
  # defp user_plug(conn, _), do: Map.put(conn, :user, Delete.Users.get_user())
  # plug(:user_plug)

  def index(conn, _params) do
    render(conn, "index.html")
  end
end

I have init_mode set in my config:

config :phoenix, :plug_init_mode, :runtime

With the above setup, using the module UserPlug, updating Users recompiles PageController.

As my app grows, I will re-use this plug in all/most of controllers (as well as other similar plugs). Is it possible to share this plug around my various controllers without creating compile time dependencies all over the place?

Showing Posts 1 to 2

josevalim

josevalim

Creator of Elixir

It was a bug. It has been fixed on Phoenix master and v1.4 branches.

jmurphyweb

jmurphyweb OP

Thanks @josevalim

By v1.4 branches I take that to mean all phoenix versions: 1.4.x but obviously that is wrong as I have the following dependency: {:phoenix, "~> 1.4.14"}.

When updating to {:phoenix, git: "https://github.com/phoenixframework/phoenix.git"} I can see that both the function plug or the module plug do not create these implicit compile time dependencies.


In case anyone else is coming across this, the following does still of course cause implicit compile time dependency:

defmodule DeleteWeb.FunctionPlugs do
  def user_plug(_, _), do: Delete.Users.get_user()
end
defmodule DeleteWeb.PageController do
  use DeleteWeb, :controller

  # plug(DeleteWeb.Plugs.User)

  # defp user_plug(_, _), do: Delete.Users.get_user()
  # plug(:user_plug)

  import DeleteWeb.FunctionPlugs, only: [user_plug: 2]
  plug(:user_plug)

  def index(conn, _params) do
    render(conn, "index.html")
  end
end

So shared plugs are better to be Module Plugs rather than imported function plugs.

— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
Onor.io
I have what I’ve heard referred to as a “lookup table” in my database. This is a way of assigning codes to common values. One common lo...
New
Trolleger
What approach to take when sending live updates to “random” users Hi! I have a question, I have a little chat app, and when I create a DM...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
wintermeyer
There are three potential reasons for members of this forum to have a look at https://vutuv.de You are tired or annoyed of LinkedIn. Yo...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews