Do you always add a trailing comma?

Looks ugly, but I do it so that code diffs better reflect the actual change after an addition…

I would add them, but formatter removes them after that. So while I would prefer to have trailing commas (but only in multiline expressions) I stopped using them as that is what code formatter expects.

So there unfortunately is no option for me in this survey

Oh I didn’t know that

I actually prefer them without (think I might have slight OCD, lol) but I’m sure I read in one of my Ruby books once that it was best to add them.

The main problem in Elixir is that trailing comma isn’t always possible, ex.:

def foo(a, b), do: {a, b}

# Legal
foo(10,
    20
)

# Legal
foo(10,
    a: 20
)

# Legal
foo(10
    a: 20,
)

# Illegal
# foo(10,
#     20,
# )

Exactly in the camp where @hauleth is: I always add them for consistency and smaller diffs but the formatter always removes them.

I don’t add them unless the formatter adds them for me. That’s the case for the Javascript stuff I work on and not for the Elixir stuff. When I had to manually added them, I actually felt like I ended up doing more work. Now that formatters add/remove them for me, I don’t care that much. The smaller diff is only slightly compelling to me.

Another +1 to adding trailing commas on multi-line lists/maps/etc… I always prefer them, diff’s, moving, etc… are always cleaner, but the formatter for some reason thinks more noisy diffs are more useful for reasons that I don’t understand… ^.^;

I much prefer them but yeah, formatter. Our eslint config requires them for javascript.

I can’t do trailing commas. I think it’s an OCD thing for me or something.

I imagine Elm’s leading commas would drive you to distraction …