Qqwy

Qqwy

TypeCheck Core Team

I am working on the MapDiff library, so it works better when structs are passed to it.

I wrote the following two doctests:

  iex> defmodule Foo do
  ...>  defstruct a: 1, b: 2, c: 3
  ...> end
  ...> MapDiff.diff(%Foo{}, %Foo{a: 3})
  %{changed: :map_change, struct_name: Foo,
    value: %{a: %{added: 3, changed: :primitive_change, removed: 1},
      b: %{changed: :equal, value: 2}, c: %{changed: :equal, value: 3}}}

and:

  iex> defmodule Bar do
  ...> defstruct a: 1, b: 2, c: 3
  ...> end
  ...> defmodule Baz do
  ...> defstruct a: "foo", b: "bar", z: "baz"
  ...> end
  ...> MapDiff.diff(%Bar{}, %Baz{})
  %{added: %Baz{a: "foo", b: "bar", z: "baz"}, changed: :primitive_change,
    removed: %Bar{a: 1, b: 2, c: 3}}

However, this will not compile. When running mix test, the following error is thrown:

Compiling 1 file (.ex)
** (CompileError) (for doctest at) lib/map_diff.ex:105: MapDiffTest.Foo.__struct__/1 is undefined, cannot expand struct MapDiffTest.Foo
    (stdlib) lists.erl:1354: :lists.mapfoldl/3
    test/map_diff_test.exs:3: anonymous fn/3 in :elixir_compiler_1.__MODULE__/1
    (elixir) lib/enum.ex:1755: Enum."-reduce/3-lists^foldl/2-0-"/3
    test/map_diff_test.exs:3: (module)

I think that this is the case because Elixir tries to evaluate the outcome value decoupled from the example, which means that Foo, Bar and Baz (and their respective __struct__/1 implementations) are not in scope.

Now, how can these doctests be rewritten so:

  • they compile.
  • it is clear to people that Foo, Bar and Baz are normal structs they could define themselves?

Showing Posts 2 to 1

Qqwy

Qqwy OP

TypeCheck Core Team

Yes! This solution works wonderfully :slight_smile: .

I ended up simply defining the structs in the tests/map_diff_test.exs file, inside the MapDiffTest module, before doctest MapDiff is being called, because it seemed the most clear (as long as the code does not become much longer.)

Thank you very much :blush:!

vic

vic

Asdf Core Team

I guess the best would be to define those example structs somewhere like in test/support then just add a comment about their structure on your docs (indent the code four spaces so that it gets properly highlighted as elixir code) and then just import them for doctest:

@doc """
   For example suppose you define the following structs:

     defmodule Bar do
       defstruct a: 1, b: 2, c: 3
     end

      defmodule Baz do
        defstruct a: "foo", b: "bar", z: "baz"
      end   
   

       iex> import Foo
       iex> import Bar
       iex> MapDiff.diff(%Foo{}, %Bar{})
       %{added: %Baz ....}
"""
— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews