rmoorman

rmoorman

The documentation of Kernel.pop_in/2 states the following:

In case any entry returns nil , its key will be removed and the deletion will be considered a success.

The accompanying example shows a nested map where the first entry (from the path passed to pop_in) is not found in the passed data:

iex> users = %{"john" => %{age: 27}, "meg" => %{age: 23}}
iex> pop_in(users, ["jane", :age])
{nil, %{"john" => %{age: 27}, "meg" => %{age: 23}}}

Nothing notable happens to the map as there is no "jane" key at all, as expected.

But how about "jane" being there but not having an age field or even not having any data assigned at all (yet)?

iex> users = %{"john" => %{age: 27}, "meg" => %{age: 23}, "jane" => %{}}
iex> pop_in(users, ["jane", :age])                                      
{nil, %{"jane" => %{}, "john" => %{age: 27}, "meg" => %{age: 23}}}

Here an empty map was assigned to jane and we got an empty map for jane back. Still seems to be allright. But when the value for "jane" is set to nil, the pop_in/2 function will remove the "jane" key.

iex> users = %{"john" => %{age: 27}, "meg" => %{age: 23}, "jane" => nil}
iex> pop_in(users, ["jane", :age])
{nil, %{"john" => %{age: 27}, "meg" => %{age: 23}}}

This matches the description inside the documentation to the letter… Maybe it’s just me, but does it make sense to remove "jane" altogether while pop_in/2 targets the :age field within the data for "jane"?
In other words: Does it make sense to remove the player "Elmo" in the following example entirely when targeting the :cash field inside his :inventory but he actually hasn’t any associated data yet?

iex> players = %{"Elmo" => nil}
iex> pop_in(players, ["Elmo", :inventory, :cash])                   
{nil, %{}}

Showing Posts 6 to 1

rmoorman

rmoorman OP

I also mentioned in the OP that pop_in/2 behaves exactly as it is documented. I also missed that initially so that could be emphasized :slightly_smiling_face:

Anyway, my point is to question whether it is sensible to remove the data altogether. I am glad that there are others finding the current behavior counter-intuitive to a varying degree!

It seems that the pop_in/2 function came to be as a renamed modification of a delete_in/2 function. Maybe it does make a little more sense in the context of deleting things nested inside a data structure, I don’t know.
Anyway, I hope he doesn’t mind dragging him into this, but @josevalim, what is your point of view in this matter?

ityonemo

ityonemo

Wow. I missed that sentence! Maybe it should be put in a warning block!

kip

kip

ex_cldr Core Team

I think the documentation is very clear about this specific case. But it does seem unexpected.

ityonemo

ityonemo

It definitely feels wrong to me, though I also feel like you should never wind up in that situation. at the very least this behaviour should be documented.

rmoorman

rmoorman OP

Do you mean that it does not feel right to you either because Elmo’s data (even though it is “just” nil) is removed entirely? (which is indeed what the op is about)

kip

kip

ex_cldr Core Team

I think the way to think about this is that Elmo does it fact have data - its just that the data is the atom nil.

— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Cxx-mlr
I’m working on a small exercise involving update_in/3, and I came up with this solution: data = %{ name: "Periodic Table", category:...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
New
budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews